From patchwork Wed Jun 18 16:40:11 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Lieven X-Patchwork-Id: 361651 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id E910C140084 for ; Thu, 19 Jun 2014 02:43:46 +1000 (EST) Received: from localhost ([::1]:59183 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxIxc-0000fp-Ve for incoming@patchwork.ozlabs.org; Wed, 18 Jun 2014 12:43:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42669) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxIut-0006DK-5J for qemu-devel@nongnu.org; Wed, 18 Jun 2014 12:41:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxIum-00017q-CY for qemu-devel@nongnu.org; Wed, 18 Jun 2014 12:40:54 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:47857 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxIum-00017g-0c for qemu-devel@nongnu.org; Wed, 18 Jun 2014 12:40:48 -0400 Received: (qmail 29566 invoked by uid 89); 18 Jun 2014 16:40:44 -0000 Received: from [82.141.1.145] by client-16-kamp (envelope-from , uid 89) with qmail-scanner-2010/03/19-MF (clamdscan: 0.98.4/19110. hbedv: 8.3.20.10/7.11.155.128. spamassassin: 3.4.0. Clear:RC:1(82.141.1.145):SA:0(-1.5/4.0):. Processed in 1.390389 secs); 18 Jun 2014 16:40:44 -0000 Received: from ns.kamp-intra.net (HELO dns.kamp-intra.net) ([82.141.1.145]) by mx01.kamp.de with SMTP; 18 Jun 2014 16:40:42 -0000 X-GL_Whitelist: yes Received: from lieven-pc.kamp-intra.net (lieven-pc.kamp-intra.net [172.21.12.60]) by dns.kamp-intra.net (Postfix) with ESMTP id A787620020; Wed, 18 Jun 2014 18:40:12 +0200 (CEST) Received: by lieven-pc.kamp-intra.net (Postfix, from userid 1000) id 9DBED5FBD1; Wed, 18 Jun 2014 18:40:12 +0200 (CEST) From: Peter Lieven To: qemu-devel@nongnu.org Date: Wed, 18 Jun 2014 18:40:11 +0200 Message-Id: <1403109611-12289-1-git-send-email-pl@kamp.de> X-Mailer: git-send-email 1.7.9.5 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a02:248:0:51::16 Cc: kwolf@redhat.com, pbonzini@redhat.com, Peter Lieven , stefanha@redhat.com Subject: [Qemu-devel] [PATCH] block/iscsi: fix init value for iTask->retries X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org during rebasing the changed init value for the retry counter was missed. This resulted in no retries being performed at all. Signed-off-by: Peter Lieven --- block/iscsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index 83c7992..327353c 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -216,7 +216,6 @@ static void iscsi_co_init_iscsitask(IscsiLun *iscsilun, struct IscsiTask *iTask) { *iTask = (struct IscsiTask) { .co = qemu_coroutine_self(), - .retries = ISCSI_CMD_RETRIES, .iscsilun = iscsilun, }; }