From patchwork Tue May 20 15:07:59 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Apfelbaum X-Patchwork-Id: 350749 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 67C7E140083 for ; Wed, 21 May 2014 01:08:25 +1000 (EST) Received: from localhost ([::1]:53876 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmleR-0001z2-2n for incoming@patchwork.ozlabs.org; Tue, 20 May 2014 11:08:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wmle0-0001YK-JH for qemu-devel@nongnu.org; Tue, 20 May 2014 11:08:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wmldu-0005ZP-Dv for qemu-devel@nongnu.org; Tue, 20 May 2014 11:07:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9247) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wmldu-0005Yq-78 for qemu-devel@nongnu.org; Tue, 20 May 2014 11:07:50 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4KF7kF4028493 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 May 2014 11:07:46 -0400 Received: from localhost.tlv.redhat.com ([10.35.214.58]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4KF7hJK022976; Tue, 20 May 2014 11:07:44 -0400 From: Marcel Apfelbaum To: qemu-devel@nongnu.org Date: Tue, 20 May 2014 18:07:59 +0300 Message-Id: <1400598479-27118-1-git-send-email-marcel.a@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: mdroth@linux.vnet.ibm.com, armbru@redhat.com, lcapitulino@redhat.com, akong@redhat.com, afaerber@suse.de Subject: [Qemu-devel] [PATCH] tests: check empty qmp output visitor X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Checks the output visitor behaviour for NULL values. Signed-off-by: Marcel Apfelbaum --- Notes: - I didn't add Michael's Sob because I tweaked the test a little. - To be added on top of "qapi: output visitor crashes qemu if it encounters a NULL value", otherwise the test will fail. tests/test-qmp-output-visitor.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/tests/test-qmp-output-visitor.c b/tests/test-qmp-output-visitor.c index 9c15458..de1bf83 100644 --- a/tests/test-qmp-output-visitor.c +++ b/tests/test-qmp-output-visitor.c @@ -507,6 +507,19 @@ static void test_visitor_out_union_anon(TestOutputVisitorData *data, qapi_free_UserDefAnonUnion(tmp); } +static void test_visitor_out_empty(TestOutputVisitorData *data, + const void *unused) +{ + QObject *arg; + QDict *qdict; + + arg = qmp_output_get_qobject(data->qov); + if (arg) { + qdict = qobject_to_qdict(arg); + QDECREF(qdict); + } +} + static void init_native_list(UserDefNativeListUnion *cvalue) { int i; @@ -859,6 +872,8 @@ int main(int argc, char **argv) &out_visitor_data, test_visitor_out_union_flat); output_visitor_test_add("/visitor/output/union-anon", &out_visitor_data, test_visitor_out_union_anon); + output_visitor_test_add("/visitor/output/empty", + &out_visitor_data, test_visitor_out_empty); output_visitor_test_add("/visitor/output/native_list/int", &out_visitor_data, test_visitor_out_native_list_int); output_visitor_test_add("/visitor/output/native_list/int8",