From patchwork Tue May 6 15:39:03 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Blake X-Patchwork-Id: 346243 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id D1F821413AC for ; Wed, 7 May 2014 01:39:47 +1000 (EST) Received: from localhost ([::1]:36003 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhhT7-0005Du-Nh for incoming@patchwork.ozlabs.org; Tue, 06 May 2014 11:39:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhhSh-0004fb-TC for qemu-devel@nongnu.org; Tue, 06 May 2014 11:39:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhhSZ-0003Xq-Gl for qemu-devel@nongnu.org; Tue, 06 May 2014 11:39:19 -0400 Received: from qmta03.emeryville.ca.mail.comcast.net ([76.96.30.32]:58955) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhhSZ-0003Xd-71 for qemu-devel@nongnu.org; Tue, 06 May 2014 11:39:11 -0400 Received: from omta18.emeryville.ca.mail.comcast.net ([76.96.30.74]) by qmta03.emeryville.ca.mail.comcast.net with comcast id ydwx1n0081bwxycA3ff977; Tue, 06 May 2014 15:39:09 +0000 Received: from red.redhat.com ([24.10.254.122]) by omta18.emeryville.ca.mail.comcast.net with comcast id yff41n00P2fD5rL8eff8cK; Tue, 06 May 2014 15:39:09 +0000 From: Eric Blake To: qemu-devel@nongnu.org Date: Tue, 6 May 2014 09:39:03 -0600 Message-Id: <1399390743-21802-1-git-send-email-eblake@redhat.com> X-Mailer: git-send-email 1.9.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20140121; t=1399390749; bh=/OHgHJsbAf4lR9UVGGTkm8FO+DRRB6zTrG4ThZq7VW0=; h=Received:Received:From:To:Subject:Date:Message-Id; b=HRWtiaSXu4ehkR/+6C7yYDO8uWO2G14wOfpnNo3BIN4uHsg/IzSMxFwLpbRHzcAEB WB7szWk0O6hHUn0wp+yONcXdCduhMSPvE4gvVUhsRH0hVTQ9kvwKZdLPykZ7FdxGfg 2op1Ip4KAqIgA0buk575EMq6nOW+iQxOGpYd8pWIv2sKJ9lFpX5/yoyekcSRXIB+02 19m/QO4HDSmeT/WEP3DWUECD9/lBwnk7EIjouCmOdNTrRKEq7eDhee0ZFmUGxpOXXT nKNNz5Lvy28anlZSYmXiRzeCkg3xDdoYnOi8Z2Vj8GIHcg7kOmARksz9pcqRaPdHXO wU0QXMDUwcz1A== X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 76.96.30.32 Cc: qemu-trivial@nongnu.org, lcapitulino@redhat.com Subject: [Qemu-devel] [PATCH] qmp: use valid JSON in transaction example X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Our example should use the correct quotes to match what someone could actually pass over the wire. * qmp-commands.hx: Use correct JSON quotes. Signed-off-by: Eric Blake --- qmp-commands.hx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index ed3ab92..e20fcf0 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -1165,19 +1165,19 @@ Example: -> { "execute": "transaction", "arguments": { "actions": [ - { 'type': 'blockdev-snapshot-sync', 'data' : { "device": "ide-hd0", + { "type": "blockdev-snapshot-sync", "data" : { "device": "ide-hd0", "snapshot-file": "/some/place/my-image", "format": "qcow2" } }, - { 'type': 'blockdev-snapshot-sync', 'data' : { "node-name": "myfile", + { "type": "blockdev-snapshot-sync", "data" : { "node-name": "myfile", "snapshot-file": "/some/place/my-image2", "snapshot-node-name": "node3432", "mode": "existing", "format": "qcow2" } }, - { 'type': 'blockdev-snapshot-sync', 'data' : { "device": "ide-hd1", + { "type": "blockdev-snapshot-sync", "data" : { "device": "ide-hd1", "snapshot-file": "/some/place/my-image2", "mode": "existing", "format": "qcow2" } }, - { 'type': 'blockdev-snapshot-internal-sync', 'data' : { + { "type": "blockdev-snapshot-internal-sync", "data" : { "device": "ide-hd2", "name": "snapshot0" } } ] } } <- { "return": {} }