diff mbox

qmp: use valid JSON in transaction example

Message ID 1399390743-21802-1-git-send-email-eblake@redhat.com
State New
Headers show

Commit Message

Eric Blake May 6, 2014, 3:39 p.m. UTC 
Our example should use the correct quotes to match what someone
could actually pass over the wire.

* qmp-commands.hx: Use correct JSON quotes.

Signed-off-by: Eric Blake <eblake@redhat.com>
---
 qmp-commands.hx | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Luiz Capitulino May 7, 2014, 2:37 p.m. UTC | #1 
On Tue,  6 May 2014 09:39:03 -0600
Eric Blake <eblake@redhat.com> wrote:

> Our example should use the correct quotes to match what someone
> could actually pass over the wire.
> 
> * qmp-commands.hx: Use correct JSON quotes.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>

Applied to the qmp branch, thanks.

> ---
>  qmp-commands.hx | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index ed3ab92..e20fcf0 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -1165,19 +1165,19 @@ Example:
> 
>  -> { "execute": "transaction",
>       "arguments": { "actions": [
> -         { 'type': 'blockdev-snapshot-sync', 'data' : { "device": "ide-hd0",
> +         { "type": "blockdev-snapshot-sync", "data" : { "device": "ide-hd0",
>                                           "snapshot-file": "/some/place/my-image",
>                                           "format": "qcow2" } },
> -         { 'type': 'blockdev-snapshot-sync', 'data' : { "node-name": "myfile",
> +         { "type": "blockdev-snapshot-sync", "data" : { "node-name": "myfile",
>                                           "snapshot-file": "/some/place/my-image2",
>                                           "snapshot-node-name": "node3432",
>                                           "mode": "existing",
>                                           "format": "qcow2" } },
> -         { 'type': 'blockdev-snapshot-sync', 'data' : { "device": "ide-hd1",
> +         { "type": "blockdev-snapshot-sync", "data" : { "device": "ide-hd1",
>                                           "snapshot-file": "/some/place/my-image2",
>                                           "mode": "existing",
>                                           "format": "qcow2" } },
> -         { 'type': 'blockdev-snapshot-internal-sync', 'data' : {
> +         { "type": "blockdev-snapshot-internal-sync", "data" : {
>                                           "device": "ide-hd2",
>                                           "name": "snapshot0" } } ] } }
>  <- { "return": {} }
diff mbox

Patch

diff --git a/qmp-commands.hx b/qmp-commands.hx
index ed3ab92..e20fcf0 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -1165,19 +1165,19 @@  Example:

 -> { "execute": "transaction",
      "arguments": { "actions": [
-         { 'type': 'blockdev-snapshot-sync', 'data' : { "device": "ide-hd0",
+         { "type": "blockdev-snapshot-sync", "data" : { "device": "ide-hd0",
                                          "snapshot-file": "/some/place/my-image",
                                          "format": "qcow2" } },
-         { 'type': 'blockdev-snapshot-sync', 'data' : { "node-name": "myfile",
+         { "type": "blockdev-snapshot-sync", "data" : { "node-name": "myfile",
                                          "snapshot-file": "/some/place/my-image2",
                                          "snapshot-node-name": "node3432",
                                          "mode": "existing",
                                          "format": "qcow2" } },
-         { 'type': 'blockdev-snapshot-sync', 'data' : { "device": "ide-hd1",
+         { "type": "blockdev-snapshot-sync", "data" : { "device": "ide-hd1",
                                          "snapshot-file": "/some/place/my-image2",
                                          "mode": "existing",
                                          "format": "qcow2" } },
-         { 'type': 'blockdev-snapshot-internal-sync', 'data' : {
+         { "type": "blockdev-snapshot-internal-sync", "data" : {
                                          "device": "ide-hd2",
                                          "name": "snapshot0" } } ] } }
 <- { "return": {} }