From patchwork Fri Apr 11 03:59:14 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hu Tao X-Patchwork-Id: 338340 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id D5D451400A8 for ; Fri, 11 Apr 2014 14:01:58 +1000 (EST) Received: from localhost ([::1]:55658 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYSf6-0003Nl-Q9 for incoming@patchwork.ozlabs.org; Fri, 11 Apr 2014 00:01:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYSeo-00037C-Dq for qemu-devel@nongnu.org; Fri, 11 Apr 2014 00:01:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WYSej-0004wp-5H for qemu-devel@nongnu.org; Fri, 11 Apr 2014 00:01:38 -0400 Received: from [59.151.112.132] (port=34340 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYSei-0004lz-R5 for qemu-devel@nongnu.org; Fri, 11 Apr 2014 00:01:33 -0400 X-IronPort-AV: E=Sophos;i="4.97,838,1389715200"; d="scan'208";a="29130557" Received: from unknown (HELO edo.cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 11 Apr 2014 11:58:31 +0800 Received: from G08CNEXCHPEKD01.g08.fujitsu.local (localhost.localdomain [127.0.0.1]) by edo.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id s3B40tDD031579 for ; Fri, 11 Apr 2014 12:00:55 +0800 Received: from G08FNSTD100614.fnst.cn.fujitsu.com (10.167.226.102) by G08CNEXCHPEKD01.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.146.2; Fri, 11 Apr 2014 12:00:55 +0800 From: Hu Tao To: Date: Fri, 11 Apr 2014 11:59:14 +0800 Message-ID: <1397188754-10741-1-git-send-email-hutao@cn.fujitsu.com> X-Mailer: git-send-email 1.8.5.2.229.g4448466 MIME-Version: 1.0 X-Originating-IP: [10.167.226.102] X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 59.151.112.132 Subject: [Qemu-devel] [PATCH] exit qemu when unknown object type is specified by -object X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org ...to avoid assertion failure in object_new_with_type(). Can be reproduced by: qemu -object unknown-object,id=xxx Signed-off-by: Hu Tao --- qom/object.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/qom/object.c b/qom/object.c index f4de619..1e7445b 100644 --- a/qom/object.c +++ b/qom/object.c @@ -448,6 +448,11 @@ Object *object_new(const char *typename) { TypeImpl *ti = type_get_by_name(typename); + if (!ti) { + error_report("unknown object type: %s\n", typename); + exit(1); + } + return object_new_with_type(ti); }