From patchwork Thu Mar 20 18:40:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Apfelbaum X-Patchwork-Id: 332359 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 917272C00AE for ; Fri, 21 Mar 2014 05:40:18 +1100 (EST) Received: from localhost ([::1]:48727 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQht1-0001Wx-Cr for incoming@patchwork.ozlabs.org; Thu, 20 Mar 2014 14:40:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52311) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQhsg-0001Sh-TI for qemu-devel@nongnu.org; Thu, 20 Mar 2014 14:40:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQhsa-0005x1-T7 for qemu-devel@nongnu.org; Thu, 20 Mar 2014 14:39:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQhsa-0005wT-LU for qemu-devel@nongnu.org; Thu, 20 Mar 2014 14:39:48 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2KIdkcL016175 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 20 Mar 2014 14:39:46 -0400 Received: from localhost.localdomain.com (vpn1-4-192.ams2.redhat.com [10.36.4.192]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s2KIdgPv019897; Thu, 20 Mar 2014 14:39:44 -0400 From: Marcel Apfelbaum To: qemu-devel@nongnu.org Date: Thu, 20 Mar 2014 20:40:08 +0200 Message-Id: <1395340808-21352-1-git-send-email-marcel.a@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: aik@ozlabs.ru, afaerber@suse.de, mst@redhat.com Subject: [Qemu-devel] [PATCH for-2.0 V2] tests/acpi-test: do not run iasl on big endian machines X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org There is an issue with iasl on big endian machines: It cannot disassemble acpi tables taken from little endian machines, so we cannot check the expected tables. Do not run iasl on those machines until this problem is solved by the acpica community. Signed-off-by: Marcel Apfelbaum --- V1 -> V2: Addressed an offline tip for a much cleaner macro line, thanks! tests/acpi-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/acpi-test.c b/tests/acpi-test.c index 249fe03..88e876f 100644 --- a/tests/acpi-test.c +++ b/tests/acpi-test.c @@ -145,7 +145,7 @@ static uint8_t boot_sector[0x7e000] = { static const char *disk = "tests/acpi-test-disk.raw"; static const char *data_dir = "tests/acpi-test-data"; -#ifdef CONFIG_IASL +#if G_BYTE_ORDER == G_LITTLE_ENDIAN && defined(CONFIG_IASL) static const char *iasl = stringify(CONFIG_IASL); #else static const char *iasl;