From patchwork Thu Feb 13 12:03:14 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antonios Motakis X-Patchwork-Id: 319984 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 1A5102C00B0 for ; Thu, 13 Feb 2014 23:04:50 +1100 (EST) Received: from localhost ([::1]:45714 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDv27-0007YQ-Jv for incoming@patchwork.ozlabs.org; Thu, 13 Feb 2014 07:04:47 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDv1L-0007OG-U3 for qemu-devel@nongnu.org; Thu, 13 Feb 2014 07:04:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDv1F-000138-SZ for qemu-devel@nongnu.org; Thu, 13 Feb 2014 07:03:59 -0500 Received: from mail-we0-f178.google.com ([74.125.82.178]:35227) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDv1F-00012g-KA for qemu-devel@nongnu.org; Thu, 13 Feb 2014 07:03:53 -0500 Received: by mail-we0-f178.google.com with SMTP id q59so7204871wes.23 for ; Thu, 13 Feb 2014 04:03:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=g4zkElUl1EFtykHB8l+j6nbl2G7HPMbyDXMJRKVH6ek=; b=NEGAnMVYUh3laOZ4007jcTmcEo1ssXJgyWfCZuST76fj8mHCgPXR6mYUovlGRJQwWd 9Yp0iQ8TW+YNNlXGRVNiBPzOadJKpvFYDaxtMyBXN8Ah/E75XWqzVP9sVoXYEFWs+SPx 4dHacmKBYVmOnZL5wYFaJDb1FzmbxygLElSC2m2h/W/x9OkS9+79sgQ5PmSrgPtlTZw2 wZD6ijLAymYg1ddK86JAZFSG0eynhn1oiNm5EIwgQnZGkKFrrWeYhqmxDesNJq4BFSzq jlIRVt5y5SP6WtMmaqO4XIDM+Lh5Lv7z0EGLJuIoTM011ux16M8qDFz5bmMCK3LRik2v hBfA== X-Gm-Message-State: ALoCoQmOtlo8tX8Y5HDLmkkrQ01F77SU/ZDApvTjAG9GaUXxdmYqNeA7ceS8zWkmQtSJwAIzuEhX X-Received: by 10.194.240.7 with SMTP id vw7mr929440wjc.75.1392293032777; Thu, 13 Feb 2014 04:03:52 -0800 (PST) Received: from localhost.localdomain (home.tvelocity.eu. [82.67.68.96]) by mx.google.com with ESMTPSA id bj3sm4039419wjb.14.2014.02.13.04.03.50 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 13 Feb 2014 04:03:51 -0800 (PST) From: Antonios Motakis To: qemu-devel@nongnu.org, snabb-devel@googlegroups.com Date: Thu, 13 Feb 2014 13:03:14 +0100 Message-Id: <1392293009-13812-4-git-send-email-a.motakis@virtualopensystems.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1392293009-13812-1-git-send-email-a.motakis@virtualopensystems.com> References: <1392293009-13812-1-git-send-email-a.motakis@virtualopensystems.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 74.125.82.178 Cc: mst@redhat.com, Amit Shah , Michael Roth , n.nikolaev@virtualopensystems.com, Hans de Goede , Gerd Hoffmann , Anthony Liguori , lukego@gmail.com, Antonios Motakis , tech@virtualopensystems.com Subject: [Qemu-devel] [PATCH v8 03/17] Add chardev API qemu_chr_fe_set_msgfds X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This will set an array of file descriptors to the internal structures. The next time a message is sent the array will be sent as ancillary data. This feature works with the Unix domain socket backend only. Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev --- include/sysemu/char.h | 14 ++++++++ qemu-char.c | 88 ++++++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 101 insertions(+), 1 deletion(-) diff --git a/include/sysemu/char.h b/include/sysemu/char.h index 9981a6a..d99dcf6 100644 --- a/include/sysemu/char.h +++ b/include/sysemu/char.h @@ -62,6 +62,7 @@ struct CharDriverState { void (*chr_update_read_handler)(struct CharDriverState *s); int (*chr_ioctl)(struct CharDriverState *s, int cmd, void *arg); int (*get_msgfd)(struct CharDriverState *s); + int (*set_msgfds)(struct CharDriverState *s, int *fds, int num); int (*chr_add_client)(struct CharDriverState *chr, int fd); IOEventHandler *chr_event; IOCanReadHandler *chr_can_read; @@ -229,6 +230,19 @@ int qemu_chr_fe_ioctl(CharDriverState *s, int cmd, void *arg); int qemu_chr_fe_get_msgfd(CharDriverState *s); /** + * @qemu_chr_fe_set_msgfds: + * + * For backends capable of fd passing, set an array of fds to be passed with + * the next send operation. + * A subsequent call to this function before calling a write function will + * result in overwriting the fd array with the new value without being send. + * Upon writing the message the fd array is freed. + * + * Returns: -1 if fd passing isn't supported. + */ +int qemu_chr_fe_set_msgfds(CharDriverState *s, int *fds, int num); + +/** * @qemu_chr_fe_claim: * * Claim a backend before using it, should be called before calling diff --git a/qemu-char.c b/qemu-char.c index fe0636f..3a8e7e6 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -207,6 +207,11 @@ int qemu_chr_fe_get_msgfd(CharDriverState *s) return s->get_msgfd ? s->get_msgfd(s) : -1; } +int qemu_chr_fe_set_msgfds(CharDriverState *s, int *fds, int num) +{ + return s->set_msgfds ? s->set_msgfds(s, fds, num) : -1; +} + int qemu_chr_add_client(CharDriverState *s, int fd) { return s->chr_add_client ? s->chr_add_client(s, fd) : -1; @@ -2332,15 +2337,71 @@ typedef struct { int do_nodelay; int is_unix; int msgfd; + int *write_msgfds; + int write_msgfds_num; } TCPCharDriver; static gboolean tcp_chr_accept(GIOChannel *chan, GIOCondition cond, void *opaque); +#ifndef _WIN32 +static int unix_send_msgfds(CharDriverState *chr, const uint8_t *buf, int len) +{ + TCPCharDriver *s = chr->opaque; + struct msghdr msgh; + struct iovec iov; + int r; + + size_t fd_size = s->write_msgfds_num * sizeof(int); + char control[CMSG_SPACE(fd_size)]; + struct cmsghdr *cmsg; + + memset(&msgh, 0, sizeof(msgh)); + memset(control, 0, sizeof(control)); + + /* set the payload */ + iov.iov_base = (uint8_t *) buf; + iov.iov_len = len; + + msgh.msg_iov = &iov; + msgh.msg_iovlen = 1; + + msgh.msg_control = control; + msgh.msg_controllen = sizeof(control); + + cmsg = CMSG_FIRSTHDR(&msgh); + + cmsg->cmsg_len = CMSG_LEN(fd_size); + cmsg->cmsg_level = SOL_SOCKET; + cmsg->cmsg_type = SCM_RIGHTS; + memcpy(CMSG_DATA(cmsg), s->write_msgfds, fd_size); + + do { + r = sendmsg(s->fd, &msgh, 0); + } while (r < 0 && errno == EINTR); + + /* free the written msgfds, no matter what */ + if (s->write_msgfds_num) { + g_free(s->write_msgfds); + s->write_msgfds = 0; + s->write_msgfds_num = 0; + } + + return r; +} +#endif + static int tcp_chr_write(CharDriverState *chr, const uint8_t *buf, int len) { TCPCharDriver *s = chr->opaque; if (s->connected) { - return io_channel_send(s->chan, buf, len); +#ifndef _WIN32 + if (s->is_unix && s->write_msgfds_num) { + return unix_send_msgfds(chr, buf, len); + } else +#endif + { + return io_channel_send(s->chan, buf, len); + } } else { /* XXX: indicate an error ? */ return len; @@ -2415,6 +2476,25 @@ static int tcp_get_msgfd(CharDriverState *chr) return fd; } +static int tcp_set_msgfds(CharDriverState *chr, int *fds, int num) +{ + TCPCharDriver *s = chr->opaque; + + /* clear old pending fd array */ + if (s->write_msgfds) { + g_free(s->write_msgfds); + } + + if (num) { + s->write_msgfds = g_malloc(num * sizeof(int)); + memcpy(s->write_msgfds, fds, num * sizeof(int)); + } + + s->write_msgfds_num = num; + + return 0; +} + #ifndef _WIN32 static void unix_process_msgfd(CharDriverState *chr, struct msghdr *msg) { @@ -2665,6 +2745,9 @@ static void tcp_chr_close(CharDriverState *chr) } closesocket(s->listen_fd); } + if (s->write_msgfds_num) { + g_free(s->write_msgfds); + } g_free(s); qemu_chr_be_event(chr, CHR_EVENT_CLOSED); } @@ -2694,6 +2777,8 @@ static CharDriverState *qemu_chr_open_socket_fd(int fd, bool do_nodelay, s->fd = -1; s->listen_fd = -1; s->msgfd = -1; + s->write_msgfds = 0; + s->write_msgfds_num = 0; chr->filename = g_malloc(256); switch (ss.ss_family) { @@ -2725,6 +2810,7 @@ static CharDriverState *qemu_chr_open_socket_fd(int fd, bool do_nodelay, chr->chr_sync_read = tcp_chr_sync_read; chr->chr_close = tcp_chr_close; chr->get_msgfd = tcp_get_msgfd; + chr->set_msgfds = tcp_set_msgfds; chr->chr_add_client = tcp_chr_add_client; chr->chr_add_watch = tcp_chr_add_watch; /* be isn't opened until we get a connection */