From patchwork Wed Nov 27 08:12:46 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antony Pavlov X-Patchwork-Id: 294506 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B971F2C00A3 for ; Wed, 27 Nov 2013 19:06:13 +1100 (EST) Received: from localhost ([::1]:34424 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vla8P-0005ta-MY for incoming@patchwork.ozlabs.org; Wed, 27 Nov 2013 03:06:09 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vla81-0005tP-Qk for qemu-devel@nongnu.org; Wed, 27 Nov 2013 03:05:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vla7t-0002Pj-Dg for qemu-devel@nongnu.org; Wed, 27 Nov 2013 03:05:45 -0500 Received: from mail-la0-x230.google.com ([2a00:1450:4010:c03::230]:43837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vla7t-0002Pc-1a for qemu-devel@nongnu.org; Wed, 27 Nov 2013 03:05:37 -0500 Received: by mail-la0-f48.google.com with SMTP id n7so5049683lam.35 for ; Wed, 27 Nov 2013 00:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=Vk6crzq7OHnlGv6RjTSdJbwwwLU2UwOVOdKXSC4yhls=; b=fGH7foid0Mzfd3Nw1FXRNKMVNyH9xxop4b6h7F25mRCxelp8ridQpwcVf0++RFygFS KfT9+TQz+RFj7oPCNIt/IfnmTqO+X/gMy28RCIDreqV7nWFc7uxHXDYIs/CzgbOV+Hd0 WD4heUHixKtludxpvjvvFvfXSEgj7+Owt3FveFio8382LfHNSOzcIcywGXRW6wDXcS3r cbSIgRvsXvX2l3HPKm9LZZbieHqMNFSHm6lvd2apKCb/wn0pfGPYUhoQreYG76An625y VMefFCuu3ofYlLhvR5WZ+Ph2iCoen6asqiR9k/2FtVzO4LWA/F8It8e5wy8lGkYmndmR 3eFA== X-Received: by 10.112.72.233 with SMTP id g9mr27863028lbv.2.1385539535445; Wed, 27 Nov 2013 00:05:35 -0800 (PST) Received: from localhost.localdomain (broadband-95-84-154-9.nationalcablenetworks.ru. [95.84.154.9]) by mx.google.com with ESMTPSA id iy7sm26114074lbc.4.2013.11.27.00.05.33 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Nov 2013 00:05:34 -0800 (PST) From: Antony Pavlov To: qemu-devel@nongnu.org Date: Wed, 27 Nov 2013 12:12:46 +0400 Message-Id: <1385539966-15844-1-git-send-email-antonynpavlov@gmail.com> X-Mailer: git-send-email 1.8.4.4 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::230 Cc: Peter Maydell , Anthony Liguori , Antony Pavlov , Stefan Hajnoczi , Paolo Bonzini , Richard Henderson Subject: [Qemu-devel] [PATCH] configure: fix ambiguous 'DTC not present' message X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The word "DTC" (device tree compiler) sometimes sounds ambiguous. "DTC not present" sounds like "dt compiler not present" but QEMU does not need the dt compiler itself but only libfdt library from DTC distribution. The phrase "Install the DTC devel package" seems confusing as dt compiler is a development tool itself. In the Debian distribution there are separate 'libfdt' and 'device-tree-compiler' packages; moreover the Debian 'device-tree-compiler' package does not depend on libfdt. Signed-off-by: Antony Pavlov Reviewed-by: Peter Crosthwaite --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 0666228..1384bc3 100755 --- a/configure +++ b/configure @@ -2626,8 +2626,8 @@ EOF fdt_libs="-L\$(BUILD_DIR)/dtc/libfdt $fdt_libs" elif test "$fdt" = "yes" ; then # have neither and want - prompt for system/submodule install - error_exit "DTC not present. Your options:" \ - " (1) Preferred: Install the DTC devel package" \ + error_exit "libfdt not present. Your options:" \ + " (1) Preferred: Install the libfdt devel package" \ " (2) Fetch the DTC submodule, using:" \ " git submodule update --init dtc" else