From patchwork Mon Oct 14 21:52:33 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wayne Xia X-Patchwork-Id: 283480 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 280342C00DE for ; Tue, 15 Oct 2013 16:53:34 +1100 (EST) Received: from localhost ([::1]:39879 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVxZU-0003Ww-3i for incoming@patchwork.ozlabs.org; Tue, 15 Oct 2013 01:53:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVxYx-0003R8-Rd for qemu-devel@nongnu.org; Tue, 15 Oct 2013 01:53:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VVxYo-0003sg-VL for qemu-devel@nongnu.org; Tue, 15 Oct 2013 01:52:59 -0400 Received: from e28smtp08.in.ibm.com ([122.248.162.8]:39850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVxYo-0003sB-CV for qemu-devel@nongnu.org; Tue, 15 Oct 2013 01:52:50 -0400 Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 15 Oct 2013 11:22:48 +0530 Received: from d28dlp02.in.ibm.com (9.184.220.127) by e28smtp08.in.ibm.com (192.168.1.138) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 15 Oct 2013 11:22:47 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 849843940058 for ; Tue, 15 Oct 2013 11:22:27 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r9F5tRlE44564648 for ; Tue, 15 Oct 2013 11:25:27 +0530 Received: from d28av02.in.ibm.com (localhost [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r9F5qjsS000980 for ; Tue, 15 Oct 2013 11:22:46 +0530 Received: from RH64wenchao ([9.181.129.59]) by d28av02.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id r9F5qZHH000390; Tue, 15 Oct 2013 11:22:44 +0530 From: Wenchao Xia To: qemu-devel@nongnu.org Date: Tue, 15 Oct 2013 05:52:33 +0800 Message-Id: <1381787553-12497-7-git-send-email-xiawenc@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1381787553-12497-1-git-send-email-xiawenc@linux.vnet.ibm.com> References: <1381787553-12497-1-git-send-email-xiawenc@linux.vnet.ibm.com> X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13101505-2000-0000-0000-00000E1C68BD X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 122.248.162.8 Cc: kwolf@redhat.com, stefanha@gmail.com, mreitz@redhat.com, pbonzini@redhat.com, Wenchao Xia Subject: [Qemu-devel] [PATCH V4 6/6] qemu-iotests: add test for qcow2 snapshot X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This test will focus on the low level procedure of qcow2 snapshot operations, now it covers only the create operation. Overlap error paths are not checked since no good way to trigger those errors. Signed-off-by: Wenchao Xia Reviewed-by: Max Reitz --- tests/qemu-iotests/068 | 214 ++++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/068.out | 35 ++++++ tests/qemu-iotests/common.filter | 7 ++ tests/qemu-iotests/group | 1 + 4 files changed, 257 insertions(+), 0 deletions(-) create mode 100755 tests/qemu-iotests/068 create mode 100644 tests/qemu-iotests/068.out diff --git a/tests/qemu-iotests/068 b/tests/qemu-iotests/068 new file mode 100755 index 0000000..37ada84 --- /dev/null +++ b/tests/qemu-iotests/068 @@ -0,0 +1,214 @@ +#!/bin/bash +# +# qcow2 internal snapshot test +# +# Copyright (C) 2013 IBM, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . +# +owner=xiawenc@linux.vnet.ibm.com + +seq=`basename $0` +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! + +_cleanup() +{ + _cleanup_test_img + rm $TEST_DIR/blkdebug.conf +} +trap "_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common.rc +. ./common.filter +. ./common.pattern + +# only test qcow2 +_supported_fmt qcow2 +_supported_proto generic +# bind the errno correctly and filter the output of image check and qemu-img, +# if you want to run it on other OS +_supported_os Linux + + +IMGOPTS="compat=1.1" + +CLUSTER_SIZE=65536 + +SIZE=1G + +BLKDBG_TEST_IMG="blkdebug:$TEST_DIR/blkdebug.conf:$TEST_IMG" + +errno=5 + +once=on + +imm=off + + +# Start test, note that the injected errors are related to qcow2's snapshot +# logic closely, see qcow2-snapshot.c for more details. + +# path 1: fail in L1 table allocation for snapshot +echo +echo "Path 1: fail in allocation of L1 table" + +_make_test_img $SIZE + +cat > $TEST_DIR/blkdebug.conf <&1 + + +# path 2: fail in update new L1 table +echo +echo "Path 2: fail in update new L1 table for snapshot" + +_make_test_img $SIZE + +cat > $TEST_DIR/blkdebug.conf <&1 | _filter_number +$QEMU_IMG snapshot -l $TEST_IMG +_check_test_img 2>&1 + +# path 3: fail in update refcount block before write snapshot list +echo +echo "Path 3: fail in update refcount block before write snapshot list" + +_make_test_img $SIZE + +cat > $TEST_DIR/blkdebug.conf <&1 | _filter_number +$QEMU_IMG snapshot -l $TEST_IMG +_check_test_img 2>&1 + +# path 4: fail in snapshot list allocation or its flush it is possible +# qcow2_alloc_clusters() not fail immediately since cache hit, but in any +# case, no error should be found in image check. +echo +echo "Path 4: fail in snapshot list allocation or its flush" + +_make_test_img $SIZE + +cat > $TEST_DIR/blkdebug.conf <&1 | grep "Failed" | grep "allocation" | grep "list"` +if ! test -z "$err" +then + echo "Error happens as expected" +fi +$QEMU_IMG snapshot -l $TEST_IMG +_check_test_img 2>&1 + + +# path 5: fail in snapshot list update +echo +echo "Path 5: fail in snapshot list update" + +_make_test_img $SIZE + +cat > $TEST_DIR/blkdebug.conf <&1 | _filter_number +$QEMU_IMG snapshot -l $TEST_IMG +_check_test_img 2>&1 + +# path 6: fail in flush after snapshot list update, no good way to trigger it, +# since the cache is empty and makes flush do nothing in that call, so leave +# this path not tested + +# path 7: fail in update qcow2 header, it would have leaked cluster since not +# discard the allocated ones for safe reason, see qcow2-snapshot.c. +echo +echo "Path 7: fail in update qcow2 header" + +_make_test_img $SIZE + +cat > $TEST_DIR/blkdebug.conf <&1 | _filter_number +$QEMU_IMG snapshot -l $TEST_IMG +_check_test_img 2>&1 | _filter_number + +# path 8: fail in overlap check before update L1 table for snapshot +# path 9: fail in overlap check before update snapshot list +# Since those clusters are allocated at runtime, there is no good way to +# make them overlap in this script, so skip those two paths now. + +# success, all done +echo "*** done" +rm -f $seq.full +status=0 diff --git a/tests/qemu-iotests/068.out b/tests/qemu-iotests/068.out new file mode 100644 index 0000000..2e111c9 --- /dev/null +++ b/tests/qemu-iotests/068.out @@ -0,0 +1,35 @@ +QA output created by 068 + +Path 1: fail in allocation of L1 table +Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1073741824 +qemu-img: Could not create snapshot 'snap1': Failed in allocation of snapshot L1 table: -5 (Input/output error) +No errors were found on the image. + +Path 2: fail in update new L1 table for snapshot +Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1073741824 +qemu-img: Could not create snapshot 'snap1': Failed in update of snapshot L1 table at X with size X: -5 (Input/output error) +No errors were found on the image. + +Path 3: fail in update refcount block before write snapshot list +Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1073741824 +qemu-img: Could not create snapshot 'snap1': Failed in update of refcount for snapshot at X with size X: -5 (Input/output error) +No errors were found on the image. + +Path 4: fail in snapshot list allocation or its flush +Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1073741824 +Error happens as expected +No errors were found on the image. + +Path 5: fail in snapshot list update +Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1073741824 +qemu-img: Could not create snapshot 'snap1': Failed in write of snapshot header at X with size X: -5 (Input/output error) +No errors were found on the image. + +Path 7: fail in update qcow2 header +Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1073741824 +qemu-img: Could not create snapshot 'snap1': Failed in update of image header at X with size X: -5 (Input/output error) +Leaked cluster X refcount=X reference=X + +1 leaked clusters were found on the image. +This means waste of disk space, but no harm to data. +*** done diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter index 8e7b1a4..e8eba65 100644 --- a/tests/qemu-iotests/common.filter +++ b/tests/qemu-iotests/common.filter @@ -146,6 +146,13 @@ _filter_win32() sed -e 's/\r//g' } +# replace number with X +_filter_number() +{ + sed -e 's/ \([0-9]\+\)/ X/g' \ + -e 's/=\([0-9]\+\)/=X/g' +} + # sanitize qemu-io output _filter_qemu_io() { diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group index 13c5500..3ca9cba 100644 --- a/tests/qemu-iotests/group +++ b/tests/qemu-iotests/group @@ -73,3 +73,4 @@ 065 rw auto 066 rw auto 067 rw auto +068 rw auto