From patchwork Mon Sep 9 02:57:59 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wayne Xia X-Patchwork-Id: 273475 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C97612C0126 for ; Mon, 9 Sep 2013 13:01:59 +1000 (EST) Received: from localhost ([::1]:47415 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VIrjh-0002Ef-VX for incoming@patchwork.ozlabs.org; Sun, 08 Sep 2013 23:01:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47964) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VIrgQ-0005V3-UB for qemu-devel@nongnu.org; Sun, 08 Sep 2013 22:58:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VIrgC-0000iN-Ny for qemu-devel@nongnu.org; Sun, 08 Sep 2013 22:58:34 -0400 Received: from e28smtp03.in.ibm.com ([122.248.162.3]:45880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VIrgC-0000hQ-1z for qemu-devel@nongnu.org; Sun, 08 Sep 2013 22:58:20 -0400 Received: from /spool/local by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 9 Sep 2013 08:20:02 +0530 Received: from d28dlp02.in.ibm.com (9.184.220.127) by e28smtp03.in.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 9 Sep 2013 08:20:00 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 61A28394004E for ; Mon, 9 Sep 2013 08:28:01 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r89307uk44499100 for ; Mon, 9 Sep 2013 08:30:07 +0530 Received: from d28av02.in.ibm.com (localhost [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r892wDAM007966 for ; Mon, 9 Sep 2013 08:28:13 +0530 Received: from RH64wenchao ([9.181.129.59]) by d28av02.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id r892w6dm007807; Mon, 9 Sep 2013 08:28:12 +0530 From: Wenchao Xia To: qemu-devel@nongnu.org Date: Mon, 9 Sep 2013 10:57:59 +0800 Message-Id: <1378695482-29805-5-git-send-email-xiawenc@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1378695482-29805-1-git-send-email-xiawenc@linux.vnet.ibm.com> References: <1378695482-29805-1-git-send-email-xiawenc@linux.vnet.ibm.com> X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13090902-3864-0000-0000-000009F992F8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 122.248.162.3 Cc: kwolf@redhat.com, pbonzini@redhat.com, mreitz@redhat.com, Wenchao Xia , stefanha@gmail.com Subject: [Qemu-devel] [PATCH V3 4/7] blkdebug: add debug events for snapshot X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Some code in qcow2-snapshot.c directly access bs->file, so in those points error can't be injected by other events. Since the code in qcow2-snapshot.c is qcow2's internal detail similar as L1 table, so add some debug events. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake --- block/blkdebug.c | 4 ++++ include/block/block.h | 4 ++++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index 5d33e03..30eda44 100644 --- a/block/blkdebug.c +++ b/block/blkdebug.c @@ -186,6 +186,10 @@ static const char *event_names[BLKDBG_EVENT_MAX] = { [BLKDBG_FLUSH_TO_OS] = "flush_to_os", [BLKDBG_FLUSH_TO_DISK] = "flush_to_disk", + + [BLKDBG_SNAPSHOT_L1_UPDATE] = "snapshot_l1_update", + [BLKDBG_SNAPSHOT_LIST_UPDATE] = "snapshot_list_update", + [BLKDBG_SNAPSHOT_HEADER_UPDATE] = "snapshot_header_update", }; static int get_event_by_name(const char *name, BlkDebugEvent *event) diff --git a/include/block/block.h b/include/block/block.h index e6b391c..e62098d 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -432,6 +432,10 @@ typedef enum { BLKDBG_FLUSH_TO_OS, BLKDBG_FLUSH_TO_DISK, + BLKDBG_SNAPSHOT_L1_UPDATE, + BLKDBG_SNAPSHOT_LIST_UPDATE, + BLKDBG_SNAPSHOT_HEADER_UPDATE, + BLKDBG_EVENT_MAX, } BlkDebugEvent;