| Message ID | 1377279256-4303-1-git-send-email-christoffer.dall@linaro.org |
|---|---|
| State | New |
| Headers | show |
Am 23.08.2013 19:34, schrieb Christoffer Dall: > The printf args are uint64_t and with -Werr QEMU doesn't compile with > migration debugging turned on unless this is fixed. Fix it. > > Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org> > --- > > [Changelog v1 -> v2]: > - Use PRIu64 instead of %llu > > migration.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/migration.c b/migration.c > index 1402fa7..e9b83f6 100644 > --- a/migration.c > +++ b/migration.c > @@ -566,7 +566,8 @@ static void *migration_thread(void *opaque) > if (!qemu_file_rate_limit(s->file)) { > DPRINTF("iterate\n"); > pending_size = qemu_savevm_state_pending(s->file, max_size); > - DPRINTF("pending size %lu max %lu\n", pending_size, max_size); > + DPRINTF("pending size %" PRIu64 " max %" PRIu64 "\n", > + pending_size, max_size); > if (pending_size && pending_size >= max_size) { > qemu_savevm_state_iterate(s->file); > } else { Reviewed-by: Stefan Weil <sw@weilnetz.de> max_size is not uint64_t but int64_t, so PRId64 would be even better for that argument, but I don't think this is worth an additional iteration. CC'ing qemu-trivial, the patch can be applied there. Regards, Stefan
Christoffer Dall <christoffer.dall@linaro.org> wrote: > The printf args are uint64_t and with -Werr QEMU doesn't compile with > migration debugging turned on unless this is fixed. Fix it. > > Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org> Reviewed-by: Juan Quintela <quintela@redhat.com>
diff --git a/migration.c b/migration.c index 1402fa7..e9b83f6 100644 --- a/migration.c +++ b/migration.c @@ -566,7 +566,8 @@ static void *migration_thread(void *opaque) if (!qemu_file_rate_limit(s->file)) { DPRINTF("iterate\n"); pending_size = qemu_savevm_state_pending(s->file, max_size); - DPRINTF("pending size %lu max %lu\n", pending_size, max_size); + DPRINTF("pending size %" PRIu64 " max %" PRIu64 "\n", + pending_size, max_size); if (pending_size && pending_size >= max_size) { qemu_savevm_state_iterate(s->file); } else {
The printf args are uint64_t and with -Werr QEMU doesn't compile with migration debugging turned on unless this is fixed. Fix it. Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org> --- [Changelog v1 -> v2]: - Use PRIu64 instead of %llu migration.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)