From patchwork Thu Aug 22 12:48:20 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Apfelbaum X-Patchwork-Id: 269046 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B7C452C0098 for ; Thu, 22 Aug 2013 22:48:57 +1000 (EST) Received: from localhost ([::1]:59668 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCUJq-0007Wa-8v for incoming@patchwork.ozlabs.org; Thu, 22 Aug 2013 08:48:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCUJW-0007OY-2y for qemu-devel@nongnu.org; Thu, 22 Aug 2013 08:48:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCUJN-0008Ka-If for qemu-devel@nongnu.org; Thu, 22 Aug 2013 08:48:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35113) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCUJN-0008J3-BL for qemu-devel@nongnu.org; Thu, 22 Aug 2013 08:48:25 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7MCmOjw016067 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 22 Aug 2013 08:48:24 -0400 Received: from localhost.tlv.redhat.com (dhcp-4-195.tlv.redhat.com [10.35.4.195]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7MCmLfI000970; Thu, 22 Aug 2013 08:48:22 -0400 From: Marcel Apfelbaum To: qemu-devel@nongnu.org Date: Thu, 22 Aug 2013 15:48:20 +0300 Message-Id: <1377175700-16229-1-git-send-email-marcel.a@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: aliguori@us.ibm.com, Marcel Apfelbaum , mst@redhat.com, armbru@redhat.com, pbonzini@redhat.com, afaerber@suse.de Subject: [Qemu-devel] [PATCH ] qemu-help: add category headlines X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This patch follows Markus Armbruster suggestion: A possibly better way to group help by category: instead of adding categories to each line, add category headlines, like this: Controller/Bridge/Hub devices: name "NAME", bus "BUS"... ... USB devices: name "NAME", bus "BUS"... ... Storage devices: ... This way, showing devices with multiple categories once per category actually makes sense. Note that the "categories to each line" is kept for 2 reasons: 1. Preparation for multifunction devices 2. Ability to grep by category Signed-off-by: Marcel Apfelbaum --- qdev-monitor.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qdev-monitor.c b/qdev-monitor.c index 410cdcb..a7329b0 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c @@ -156,6 +156,8 @@ static void qdev_print_category_devices(DeviceCategory category) DeviceClass *dc; GSList *list, *curr; + error_printf("%s devices:\n", qdev_category_get_name(category)); + list = object_class_get_list(TYPE_DEVICE, false); for (curr = list; curr; curr = g_slist_next(curr)) { dc = (DeviceClass *)object_class_dynamic_cast(curr->data, TYPE_DEVICE);