From patchwork Thu Aug 1 14:32:44 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 264031 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 42F882C0084 for ; Fri, 2 Aug 2013 00:33:33 +1000 (EST) Received: from localhost ([::1]:34398 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4twZ-0005dt-5I for incoming@patchwork.ozlabs.org; Thu, 01 Aug 2013 10:33:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4tw4-0005Uf-5j for qemu-devel@nongnu.org; Thu, 01 Aug 2013 10:33:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V4tvy-00079Q-6d for qemu-devel@nongnu.org; Thu, 01 Aug 2013 10:33:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8028) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4tvx-00079I-WC for qemu-devel@nongnu.org; Thu, 01 Aug 2013 10:32:54 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r71EWq6p013143 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 1 Aug 2013 10:32:53 -0400 Received: from localhost (ovpn-113-130.phx2.redhat.com [10.3.113.130]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r71EWqa5020336; Thu, 1 Aug 2013 10:32:52 -0400 From: Luiz Capitulino To: qemu-devel@nongnu.org Date: Thu, 1 Aug 2013 10:32:44 -0400 Message-Id: <1375367564-4797-3-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1375367564-4797-1-git-send-email-lcapitulino@redhat.com> References: <1375367564-4797-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: aliguori@us.ibm.com Subject: [Qemu-devel] [PULL 2/2] migration: don't use uninitialized variables X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Pawit Pornkitprasan The qmp_migrate method uses the 'blk' and 'inc' parameter without checking if they're valid or not (they may be uninitialized if command is received via QMP) Signed-off-by: Pawit Pornkitprasan Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- migration.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration.c b/migration.c index 3f682cd..1402fa7 100644 --- a/migration.c +++ b/migration.c @@ -400,8 +400,8 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk, MigrationParams params; const char *p; - params.blk = blk; - params.shared = inc; + params.blk = has_blk && blk; + params.shared = has_inc && inc; if (s->state == MIG_STATE_ACTIVE || s->state == MIG_STATE_SETUP) { error_set(errp, QERR_MIGRATION_ACTIVE);