diff mbox

[V7,01/13] monitor: avoid use of global *cur_mon in cmd_completion()

Message ID 1374284656-12025-2-git-send-email-xiawenc@linux.vnet.ibm.com
State New
Headers show

Commit Message

Wayne Xia July 20, 2013, 1:44 a.m. UTC 
A new local variable *mon is added in monitor_find_completion()
to make compile pass, which will be removed later in
convertion patch for monitor_find_completion().

Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
---
 monitor.c |   13 +++++++------
 1 files changed, 7 insertions(+), 6 deletions(-)

Comments

Eric Blake July 20, 2013, 11:49 a.m. UTC | #1 
On 07/19/2013 07:44 PM, Wenchao Xia wrote:
> A new local variable *mon is added in monitor_find_completion()
> to make compile pass, which will be removed later in
> convertion patch for monitor_find_completion().

s/convertion/conversion/

> 
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
>  monitor.c |   13 +++++++------
>  1 files changed, 7 insertions(+), 6 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>
Wayne Xia July 20, 2013, 1:13 p.m. UTC | #2 
于 2013-7-20 19:49, Eric Blake 写道:
> On 07/19/2013 07:44 PM, Wenchao Xia wrote:
>> A new local variable *mon is added in monitor_find_completion()
>> to make compile pass, which will be removed later in
>> convertion patch for monitor_find_completion().
>
> s/convertion/conversion/
>
>>
>> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
>> ---
>>   monitor.c |   13 +++++++------
>>   1 files changed, 7 insertions(+), 6 deletions(-)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
   Thanks for review. I have read the patches sometime but
unfortunately have not found the spell problem, my bad.
Luiz, do you have other comments for this version except
the typo? If not, may I ask you for a favor to apply it
and fix the typo issues Eric have pointed out? I hope
avoid a re-spin for it, to disturb people less.
diff mbox

Patch

diff --git a/monitor.c b/monitor.c
index 6db2ba4..b88c02b 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4004,7 +4004,7 @@  out:
     QDECREF(qdict);
 }
 
-static void cmd_completion(const char *name, const char *list)
+static void cmd_completion(Monitor *mon, const char *name, const char *list)
 {
     const char *p, *pstart;
     char cmd[128];
@@ -4022,7 +4022,7 @@  static void cmd_completion(const char *name, const char *list)
         memcpy(cmd, pstart, len);
         cmd[len] = '\0';
         if (name[0] == '\0' || !strncmp(name, cmd, strlen(name))) {
-            readline_add_completion(cur_mon->rs, cmd);
+            readline_add_completion(mon->rs, cmd);
         }
         if (*p == '\0')
             break;
@@ -4136,6 +4136,7 @@  static void monitor_find_completion(const char *cmdline)
     int nb_args, i, len;
     const char *ptype, *str;
     const mon_cmd_t *cmd;
+    Monitor *mon = cur_mon;
 
     parse_cmdline(cmdline, &nb_args, args);
 #ifdef DEBUG_COMPLETION
@@ -4161,7 +4162,7 @@  static void monitor_find_completion(const char *cmdline)
             cmdname = args[0];
         readline_set_completion_index(cur_mon->rs, strlen(cmdname));
         for(cmd = mon_cmds; cmd->name != NULL; cmd++) {
-            cmd_completion(cmdname, cmd->name);
+            cmd_completion(mon, cmdname, cmd->name);
         }
     } else {
         /* find the command */
@@ -4202,7 +4203,7 @@  static void monitor_find_completion(const char *cmdline)
             if (!strcmp(cmd->name, "info")) {
                 readline_set_completion_index(cur_mon->rs, strlen(str));
                 for(cmd = info_cmds; cmd->name != NULL; cmd++) {
-                    cmd_completion(str, cmd->name);
+                    cmd_completion(mon, str, cmd->name);
                 }
             } else if (!strcmp(cmd->name, "sendkey")) {
                 char *sep = strrchr(str, '-');
@@ -4210,12 +4211,12 @@  static void monitor_find_completion(const char *cmdline)
                     str = sep + 1;
                 readline_set_completion_index(cur_mon->rs, strlen(str));
                 for (i = 0; i < Q_KEY_CODE_MAX; i++) {
-                    cmd_completion(str, QKeyCode_lookup[i]);
+                    cmd_completion(mon, str, QKeyCode_lookup[i]);
                 }
             } else if (!strcmp(cmd->name, "help|?")) {
                 readline_set_completion_index(cur_mon->rs, strlen(str));
                 for (cmd = mon_cmds; cmd->name != NULL; cmd++) {
-                    cmd_completion(str, cmd->name);
+                    cmd_completion(mon, str, cmd->name);
                 }
             }
             break;