From patchwork Wed Jul 17 20:04:22 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Main X-Patchwork-Id: 259746 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id DA8352C00AF for ; Thu, 18 Jul 2013 06:06:33 +1000 (EST) Received: from localhost ([::1]:34694 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzXzb-00005H-LR for incoming@patchwork.ozlabs.org; Wed, 17 Jul 2013 16:06:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzXxf-0005uJ-HG for qemu-devel@nongnu.org; Wed, 17 Jul 2013 16:04:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UzXxc-0003nD-UL for qemu-devel@nongnu.org; Wed, 17 Jul 2013 16:04:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30713) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzXxc-0003n4-Ms for qemu-devel@nongnu.org; Wed, 17 Jul 2013 16:04:28 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6HK4SXX024728 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 17 Jul 2013 16:04:28 -0400 Received: from arnold.mains.com (ovpn-113-76.phx2.redhat.com [10.3.113.76]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r6HK4Oig006504; Wed, 17 Jul 2013 16:04:27 -0400 From: Ian Main To: qemu-devel@nongnu.org Date: Wed, 17 Jul 2013 13:04:22 -0700 Message-Id: <1374091462-18391-5-git-send-email-imain@redhat.com> In-Reply-To: <1374091462-18391-1-git-send-email-imain@redhat.com> References: <1374091462-18391-1-git-send-email-imain@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Ian Main Subject: [Qemu-devel] [PATCH V4 4/4] Change default to qcow2 for sync mode none. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org qcow2 supports backing files so it makes sense to default to qcow2 for MIRROR_SYNC_MODE_NONE so that we can use the source as a backing drive and export it via nbd. Defaulting FULL and TOP to SYNC_MODE_NONE breaks tests but that could be fixed if we wanted it. Signed-off-by: Ian Main --- blockdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index 000dea6..805b0e5 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1462,7 +1462,7 @@ void qmp_drive_backup(const char *device, const char *target, } if (!has_format) { - format = mode == NEW_IMAGE_MODE_EXISTING ? NULL : bs->drv->format_name; + format = mode == NEW_IMAGE_MODE_EXISTING ? NULL : "qcow2"; } if (format) { drv = bdrv_find_format(format);