From patchwork Wed Jul 17 09:35:19 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 259652 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id CF8FF2C0095 for ; Wed, 17 Jul 2013 19:39:19 +1000 (EST) Received: from localhost ([::1]:59557 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzOCb-0005RR-Nx for incoming@patchwork.ozlabs.org; Wed, 17 Jul 2013 05:39:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzO9F-0000ga-7M for qemu-devel@nongnu.org; Wed, 17 Jul 2013 05:35:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UzO9C-0005Pk-Kq for qemu-devel@nongnu.org; Wed, 17 Jul 2013 05:35:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1178) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzO9C-0005PN-DC for qemu-devel@nongnu.org; Wed, 17 Jul 2013 05:35:46 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6H9ZjMO027323 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 17 Jul 2013 05:35:45 -0400 Received: from localhost (ovpn-112-21.ams2.redhat.com [10.36.112.21]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r6H9ZgVO016524; Wed, 17 Jul 2013 05:35:44 -0400 From: Stefan Hajnoczi To: Date: Wed, 17 Jul 2013 17:35:19 +0800 Message-Id: <1374053720-28420-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1374053720-28420-1-git-send-email-stefanha@redhat.com> References: <1374053720-28420-1-git-send-email-stefanha@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Kevin Wolf , Paolo Bonzini , Stefan Hajnoczi , Juan Quintela Subject: [Qemu-devel] [PATCH 2/3] migration: notify migration state before starting thread X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The migration thread runs outside the QEMU global mutex when possible. Therefore we must notify migration state change *before* starting the migration thread. This allows registered listeners to act before live migration iterations begin. Therefore they can get into a state that allows for live migration. When the migration thread starts everything will be ready. Signed-off-by: Stefan Hajnoczi Acked-by: Paolo Bonzini --- migration.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/migration.c b/migration.c index 9f5a423..b4daf13 100644 --- a/migration.c +++ b/migration.c @@ -625,7 +625,9 @@ void migrate_fd_connect(MigrationState *s) qemu_file_set_rate_limit(s->file, s->bandwidth_limit / XFER_LIMIT_RATIO); + /* Notify before starting migration thread */ + notifier_list_notify(&migration_state_notifiers, s); + qemu_thread_create(&s->thread, migration_thread, s, QEMU_THREAD_JOINABLE); - notifier_list_notify(&migration_state_notifiers, s); }