Message ID | 1373640028-5138-3-git-send-email-mrhines@linux.vnet.ibm.com |
---|---|
State | New |
Headers | show |
On 07/12/2013 08:40 AM, mrhines@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" <mrhines@us.ibm.com> > > We were not checking for a valid 'bytes_sent' pointer before accessing it. > > Signed-off-by: Michael R. Hines <mrhines@us.ibm.com> > --- > savevm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake <eblake@redhat.com> > > diff --git a/savevm.c b/savevm.c > index e0491e7..03fc4d9 100644 > --- a/savevm.c > +++ b/savevm.c > @@ -662,7 +662,7 @@ size_t ram_control_save_page(QEMUFile *f, ram_addr_t block_offset, > offset, size, bytes_sent); > > if (ret != RAM_SAVE_CONTROL_DELAYED) { > - if (*bytes_sent > 0) { > + if (bytes_sent && *bytes_sent > 0) { > qemu_update_position(f, *bytes_sent); > } else if (ret < 0) { > qemu_file_set_error(f, ret); >
diff --git a/savevm.c b/savevm.c index e0491e7..03fc4d9 100644 --- a/savevm.c +++ b/savevm.c @@ -662,7 +662,7 @@ size_t ram_control_save_page(QEMUFile *f, ram_addr_t block_offset, offset, size, bytes_sent); if (ret != RAM_SAVE_CONTROL_DELAYED) { - if (*bytes_sent > 0) { + if (bytes_sent && *bytes_sent > 0) { qemu_update_position(f, *bytes_sent); } else if (ret < 0) { qemu_file_set_error(f, ret);