From patchwork Sat Jun 22 09:24:29 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 253406 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id EBBEA2C0415 for ; Sat, 22 Jun 2013 19:34:05 +1000 (EST) Received: from localhost ([::1]:40001 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UqKCp-0002Ki-QP for incoming@patchwork.ozlabs.org; Sat, 22 Jun 2013 05:34:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UqKCH-0002F9-VQ for qemu-devel@nongnu.org; Sat, 22 Jun 2013 05:33:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UqKCF-0007ti-6o for qemu-devel@nongnu.org; Sat, 22 Jun 2013 05:33:29 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:37513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UqKCE-0007s6-Vh for qemu-devel@nongnu.org; Sat, 22 Jun 2013 05:33:27 -0400 Received: from gandalf.tls.msk.ru (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id 4E26F41E4B; Sat, 22 Jun 2013 13:33:26 +0400 (MSK) Received: by gandalf.tls.msk.ru (Postfix, from userid 1000) id CAE77564; Sat, 22 Jun 2013 13:24:39 +0400 (MSK) From: Michael Tokarev To: Anthony Liguori Date: Sat, 22 Jun 2013 13:24:29 +0400 Message-Id: <1371893076-9643-11-git-send-email-mjt@msgid.tls.msk.ru> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1371893076-9643-1-git-send-email-mjt@msgid.tls.msk.ru> References: <1371893076-9643-1-git-send-email-mjt@msgid.tls.msk.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: Anthony PERARD , Michael Tokarev , qemu-devel@nongnu.org Subject: [Qemu-devel] [PULL 10/17] qxl: Fix QXLRam initialisation. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Anthony PERARD The qxl driver expect NULL for QXLRam.memory_configs, but this is never initialized. If memory is set to 0xc2c2.., it leads to a spice-critical error when trying to start qxl. Signed-off-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Signed-off-by: Michael Tokarev --- hw/display/qxl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index c475cb1..937a402 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -387,6 +387,7 @@ static void init_qxl_ram(PCIQXLDevice *d) d->ram->int_pending = cpu_to_le32(0); d->ram->int_mask = cpu_to_le32(0); d->ram->update_surface = 0; + d->ram->monitors_config = 0; SPICE_RING_INIT(&d->ram->cmd_ring); SPICE_RING_INIT(&d->ram->cursor_ring); SPICE_RING_INIT(&d->ram->release_ring);