Message ID | 1365992066-24348-1-git-send-email-lig.fnst@cn.fujitsu.com |
---|---|
State | New |
Headers | show |
On 04/14/2013 09:14 PM, liguang wrote: > when use DEBUG_DEBUGCON, screen spits: > debugcon: write addr=0x0000 val=0x00 > Rdebugcon: write addr=0x0000 val=0x00 > udebugcon: write addr=0x0000 val=0x00 > ndebugcon: write addr=0x0000 val=0x00 > ndebugcon: write addr=0x0000 val=0x00 > idebugcon: write addr=0x0000 val=0x00 > ndebugcon: write addr=0x0000 val=0x00 > gdebugcon: write addr=0x0000 val=0x00 > debugcon: write addr=0x0000 val=0x00 > odebugcon: write addr=0x0000 val=0x00 > pdebugcon: write addr=0x0000 val=0x00 > tdebugcon: write addr=0x0000 val=0x00 > idebugcon: write addr=0x0000 val=0x00 > odebugcon: write addr=0x0000 val=0x00 > ndebugcon: write addr=0x0000 val=0x00 > debugcon: write addr=0x0000 val=0x00 > rdebugcon: write addr=0x0000 val=0x00 > odebugcon: write addr=0x0000 val=0x00 > mdebugcon: write addr=0x0000 val=0x00 > debugcon: write addr=0x0000 val=0x00 > adebugcon: write addr=0x0000 val=0x00 > tdebugcon: write addr=0x0000 val=0x00 > debugcon: write addr=0x0000 val=0x00 > > Oh, that's wrong, val is not always be 0. > this bug caused by lack of length modifier > for specifier 'x'. > > Signed-off-by: liguang <lig.fnst@cn.fujitsu.com> > --- > hw/char/debugcon.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/char/debugcon.c b/hw/char/debugcon.c > index 0588eeb..44c93e1 100644 > --- a/hw/char/debugcon.c > +++ b/hw/char/debugcon.c > @@ -55,7 +55,7 @@ static void debugcon_ioport_write(void *opaque, hwaddr addr, uint64_t val, > unsigned char ch = val; > > #ifdef DEBUG_DEBUGCON > - printf("debugcon: write addr=0x%04x val=0x%02x\n", addr, val); > + printf("debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02x\n", addr, val); > #endif > > qemu_chr_fe_write(s->chr, &ch, 1); > Reviewed-by: Jesse Larrew <jlarrew@linux.vnet.ibm.com> Jesse Larrew Software Engineer, KVM Team IBM Linux Technology Center Phone: (512) 973-2052 (T/L: 363-2052) jlarrew@linux.vnet.ibm.com
diff --git a/hw/char/debugcon.c b/hw/char/debugcon.c index 0588eeb..44c93e1 100644 --- a/hw/char/debugcon.c +++ b/hw/char/debugcon.c @@ -55,7 +55,7 @@ static void debugcon_ioport_write(void *opaque, hwaddr addr, uint64_t val, unsigned char ch = val; #ifdef DEBUG_DEBUGCON - printf("debugcon: write addr=0x%04x val=0x%02x\n", addr, val); + printf("debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02x\n", addr, val); #endif qemu_chr_fe_write(s->chr, &ch, 1);
when use DEBUG_DEBUGCON, screen spits: debugcon: write addr=0x0000 val=0x00 Rdebugcon: write addr=0x0000 val=0x00 udebugcon: write addr=0x0000 val=0x00 ndebugcon: write addr=0x0000 val=0x00 ndebugcon: write addr=0x0000 val=0x00 idebugcon: write addr=0x0000 val=0x00 ndebugcon: write addr=0x0000 val=0x00 gdebugcon: write addr=0x0000 val=0x00 debugcon: write addr=0x0000 val=0x00 odebugcon: write addr=0x0000 val=0x00 pdebugcon: write addr=0x0000 val=0x00 tdebugcon: write addr=0x0000 val=0x00 idebugcon: write addr=0x0000 val=0x00 odebugcon: write addr=0x0000 val=0x00 ndebugcon: write addr=0x0000 val=0x00 debugcon: write addr=0x0000 val=0x00 rdebugcon: write addr=0x0000 val=0x00 odebugcon: write addr=0x0000 val=0x00 mdebugcon: write addr=0x0000 val=0x00 debugcon: write addr=0x0000 val=0x00 adebugcon: write addr=0x0000 val=0x00 tdebugcon: write addr=0x0000 val=0x00 debugcon: write addr=0x0000 val=0x00 Oh, that's wrong, val is not always be 0. this bug caused by lack of length modifier for specifier 'x'. Signed-off-by: liguang <lig.fnst@cn.fujitsu.com> --- hw/char/debugcon.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)