From patchwork Fri Apr 5 14:08:43 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 234146 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id AB3862C00A0 for ; Sat, 6 Apr 2013 01:09:53 +1100 (EST) Received: from localhost ([::1]:54691 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UO7Kx-0007c5-OB for incoming@patchwork.ozlabs.org; Fri, 05 Apr 2013 10:09:51 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UO7KC-0007Pw-0T for qemu-devel@nongnu.org; Fri, 05 Apr 2013 10:09:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UO7K5-0008Gs-7E for qemu-devel@nongnu.org; Fri, 05 Apr 2013 10:09:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52893) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UO7K4-0008Gn-VY for qemu-devel@nongnu.org; Fri, 05 Apr 2013 10:08:57 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r35E8tIN003264 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 5 Apr 2013 10:08:55 -0400 Received: from localhost (ovpn-112-21.ams2.redhat.com [10.36.112.21]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r35E8sOa022380; Fri, 5 Apr 2013 10:08:54 -0400 From: Stefan Hajnoczi To: Date: Fri, 5 Apr 2013 16:08:43 +0200 Message-Id: <1365170926-6361-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1365170926-6361-1-git-send-email-stefanha@redhat.com> References: <1365170926-6361-1-git-send-email-stefanha@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Peter Maydell , Anthony Liguori , Stefan Hajnoczi Subject: [Qemu-devel] [PATCH 2/5] linux-user: Don't omit comma for strace of rt_sigaction() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Peter Maydell Pass the 'last' parameter of print_signal() through to print_raw_param(); this fixes a problem where we weren't printing the comma separator for strace of rt_sigaction() when the signal was an unnamed (ie realtime) one: 6856 rt_sigaction(230xf6fff870,0xf6fff8fc) = 0 Signed-off-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- linux-user/strace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 0fbae3c..ea6c1d2 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c @@ -143,7 +143,7 @@ print_signal(abi_ulong arg, int last) case TARGET_SIGTTOU: signal_name = "SIGTTOU"; break; } if (signal_name == NULL) { - print_raw_param("%ld", arg, 1); + print_raw_param("%ld", arg, last); return; } gemu_log("%s%s", signal_name, get_comma(last));