From patchwork Mon Apr 1 10:01:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wayne Xia X-Patchwork-Id: 232721 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 471D72C009A for ; Mon, 1 Apr 2013 21:04:57 +1100 (EST) Received: from localhost ([::1]:32815 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMbbj-0002qg-An for incoming@patchwork.ozlabs.org; Mon, 01 Apr 2013 06:04:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMbb3-0002gb-Qp for qemu-devel@nongnu.org; Mon, 01 Apr 2013 06:04:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMbav-0002aJ-Pv for qemu-devel@nongnu.org; Mon, 01 Apr 2013 06:04:13 -0400 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:36013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMbav-0002Zq-4c for qemu-devel@nongnu.org; Mon, 01 Apr 2013 06:04:05 -0400 Received: from /spool/local by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 1 Apr 2013 15:29:52 +0530 Received: from d28dlp03.in.ibm.com (9.184.220.128) by e28smtp07.in.ibm.com (192.168.1.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 1 Apr 2013 15:29:49 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 9292B1258023 for ; Mon, 1 Apr 2013 15:35:17 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r31A3r4c3670338 for ; Mon, 1 Apr 2013 15:33:53 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r31A3tDo029426 for ; Mon, 1 Apr 2013 21:03:56 +1100 Received: from RH63Wenchao (wenchaox.cn.ibm.com [9.115.122.29]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id r31A1Yha016168; Mon, 1 Apr 2013 21:03:53 +1100 From: Wenchao Xia To: qemu-devel@nongnu.org Date: Mon, 1 Apr 2013 18:01:31 +0800 Message-Id: <1364810491-21404-4-git-send-email-xiawenc@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1364810491-21404-1-git-send-email-xiawenc@linux.vnet.ibm.com> References: <1364810491-21404-1-git-send-email-xiawenc@linux.vnet.ibm.com> X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13040109-8878-0000-0000-0000068743AA X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 122.248.162.7 Cc: kwolf@redhat.com, pbonzini@redhat.com, Wenchao Xia , dietmar@proxmox.com, stefanha@gmail.com Subject: [Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Last operaton should be cancelled first. Signed-off-by: Wenchao Xia --- blockdev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/blockdev.c b/blockdev.c index 75416fb..a24d10e 100644 --- a/blockdev.c +++ b/blockdev.c @@ -954,7 +954,7 @@ void qmp_transaction(BlockdevActionList *dev_list, Error **errp) dev_entry = dev_entry->next; states = g_malloc0(sizeof(BlkTransactionStates)); - QSIMPLEQ_INSERT_TAIL(&snap_bdrv_states, states, entry); + QSIMPLEQ_INSERT_HEAD(&snap_bdrv_states, states, entry); states->action = dev_info; switch (dev_info->kind) {