From patchwork Thu Mar 28 09:03:01 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: liguang X-Patchwork-Id: 231955 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 0F5202C00FA for ; Thu, 28 Mar 2013 20:06:09 +1100 (EST) Received: from localhost ([::1]:56073 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UL8md-0002Xa-5S for incoming@patchwork.ozlabs.org; Thu, 28 Mar 2013 05:06:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UL8m3-0002XF-OZ for qemu-devel@nongnu.org; Thu, 28 Mar 2013 05:05:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UL8lz-0004IQ-7o for qemu-devel@nongnu.org; Thu, 28 Mar 2013 05:05:31 -0400 Received: from [222.73.24.84] (port=40283 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UL8ly-0004GP-Sx for qemu-devel@nongnu.org; Thu, 28 Mar 2013 05:05:27 -0400 X-IronPort-AV: E=Sophos;i="4.87,365,1363104000"; d="scan'208";a="6962409" Received: from unknown (HELO tang.cn.fujitsu.com) ([10.167.250.3]) by song.cn.fujitsu.com with ESMTP; 28 Mar 2013 17:02:46 +0800 Received: from fnstmail02.fnst.cn.fujitsu.com (tang.cn.fujitsu.com [127.0.0.1]) by tang.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id r2S95HC0026376; Thu, 28 Mar 2013 17:05:17 +0800 Received: from liguang.fnst.cn.fujitsu.com ([10.167.233.147]) by fnstmail02.fnst.cn.fujitsu.com (Lotus Domino Release 8.5.3) with ESMTP id 2013032817042726-133192 ; Thu, 28 Mar 2013 17:04:27 +0800 From: liguang To: afaerber@suse.de, qemu-devel@nongnu.org Date: Thu, 28 Mar 2013 17:03:01 +0800 Message-Id: <1364461382-20359-1-git-send-email-lig.fnst@cn.fujitsu.com> X-Mailer: git-send-email 1.7.2.5 X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/03/28 17:04:27, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/03/28 17:04:29, Serialize complete at 2013/03/28 17:04:29 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 222.73.24.84 Cc: liguang Subject: [Qemu-devel] [PATCH v2 1/2] hw/i386/pc: fix possible segment fault for port92_write X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org e.g. $qemu-system-x86_64 -device port92 will report segment fault, for port92_write try a un-allocated assignment for a20_out. so check before this assignment. Signed-off-by: liguang --- hw/i386/pc.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 09fb728..b881314 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -444,7 +444,9 @@ static void port92_write(void *opaque, hwaddr addr, uint64_t val, DPRINTF("port92: write 0x%02x\n", val); s->outport = val; - qemu_set_irq(*s->a20_out, (val >> 1) & 1); + if (s->a20_out) { + qemu_set_irq(*s->a20_out, (val >> 1) & 1); + } if (val & 1) { qemu_system_reset_request(); }