From patchwork Tue Mar 26 19:01:38 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aurelien Jarno X-Patchwork-Id: 231519 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 99DA62C008D for ; Wed, 27 Mar 2013 06:04:36 +1100 (EST) Received: from localhost ([::1]:56112 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKZAf-0008LZ-Uc for incoming@patchwork.ozlabs.org; Tue, 26 Mar 2013 15:04:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKZ8G-0004u9-6I for qemu-devel@nongnu.org; Tue, 26 Mar 2013 15:02:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKZ8A-0005rl-Hp for qemu-devel@nongnu.org; Tue, 26 Mar 2013 15:02:04 -0400 Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:49207) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKZ8A-0005nz-A8 for qemu-devel@nongnu.org; Tue, 26 Mar 2013 15:01:58 -0400 Received: from [2001:470:d4ed:0:ea11:32ff:fea1:831a] (helo=ohm.aurel32.net) by hall.aurel32.net with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1UKZ7z-0007yx-H4; Tue, 26 Mar 2013 20:01:47 +0100 Received: from aurel32 by ohm.aurel32.net with local (Exim 4.80) (envelope-from ) id 1UKZ7x-0002SF-V5; Tue, 26 Mar 2013 20:01:45 +0100 From: Aurelien Jarno To: qemu-devel@nongnu.org Date: Tue, 26 Mar 2013 20:01:38 +0100 Message-Id: <1364324502-9124-7-git-send-email-aurelien@aurel32.net> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1364324502-9124-1-git-send-email-aurelien@aurel32.net> References: <1364324502-9124-1-git-send-email-aurelien@aurel32.net> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:470:1f15:c4f::1 Cc: Aurelien Jarno Subject: [Qemu-devel] [PATCH 06/10] target-i386: SSE4.2: fix pcmpXstrX instructions in "Equal each" mode X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org pcmpXstrX instructions in "Equal each" mode force both invalid element pair to true. It means (upper - MAX(valids, validd)) bits should be set to 1, not (upper - MAX(valids, validd) + 1). Signed-off-by: Aurelien Jarno Reviewed-by: Richard Henderson --- target-i386/ops_sse.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/ops_sse.h b/target-i386/ops_sse.h index 51c5fc9..2fc5fdd 100644 --- a/target-i386/ops_sse.h +++ b/target-i386/ops_sse.h @@ -2025,7 +2025,7 @@ static inline unsigned pcmpxstrx(CPUX86State *env, Reg *d, Reg *s, } break; case 2: - res = (2 << (upper - MAX(valids, validd))) - 1; + res = (1 << (upper - MAX(valids, validd))) - 1; res <<= MAX(valids, validd) - MIN(valids, validd); for (i = MIN(valids, validd); i >= 0; i--) { res <<= 1;