From patchwork Fri Mar 15 15:14:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 228056 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id F036C2C0261 for ; Sat, 16 Mar 2013 02:21:25 +1100 (EST) Received: from localhost ([::1]:55311 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGWQE-00075W-O5 for incoming@patchwork.ozlabs.org; Fri, 15 Mar 2013 11:19:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGWLR-0007zT-B7 for qemu-devel@nongnu.org; Fri, 15 Mar 2013 11:15:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UGWLO-0004Ai-NO for qemu-devel@nongnu.org; Fri, 15 Mar 2013 11:14:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22779) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGWLO-0004AZ-Fa for qemu-devel@nongnu.org; Fri, 15 Mar 2013 11:14:54 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2FFErYl007268 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 15 Mar 2013 11:14:54 -0400 Received: from localhost (ovpn-112-50.ams2.redhat.com [10.36.112.50]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r2FFEqD1012568; Fri, 15 Mar 2013 11:14:53 -0400 From: Stefan Hajnoczi To: Date: Fri, 15 Mar 2013 16:14:11 +0100 Message-Id: <1363360465-5247-15-git-send-email-stefanha@redhat.com> In-Reply-To: <1363360465-5247-1-git-send-email-stefanha@redhat.com> References: <1363360465-5247-1-git-send-email-stefanha@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Anthony Liguori Subject: [Qemu-devel] [PATCH 14/28] qcow2: drop unnecessary flush in qcow2_update_snapshot_refcount() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org We already flush when the function completes. There is no need to flush after every compressed cluster. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 92519ea..9bfb390 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount.c @@ -790,10 +790,6 @@ int qcow2_update_snapshot_refcount(BlockDriverState *bs, if (ret < 0) { goto fail; } - - /* TODO Flushing once for the whole function should - * be enough */ - bdrv_flush(bs->file); } /* compressed clusters are never modified */ refcount = 2;