From patchwork Wed Mar 13 15:58:35 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alon Levy X-Patchwork-Id: 227306 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A7CBD2C00A0 for ; Thu, 14 Mar 2013 02:59:08 +1100 (EST) Received: from localhost ([::1]:55726 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFo54-0002Np-LC for incoming@patchwork.ozlabs.org; Wed, 13 Mar 2013 11:59:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56738) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFo4l-0002Ng-BC for qemu-devel@nongnu.org; Wed, 13 Mar 2013 11:58:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFo4f-0007dg-Tg for qemu-devel@nongnu.org; Wed, 13 Mar 2013 11:58:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFo4f-0007dN-FH for qemu-devel@nongnu.org; Wed, 13 Mar 2013 11:58:41 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2DFwceo006356 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 13 Mar 2013 11:58:39 -0400 Received: from localhost.localdomain (vpn1-7-28.ams2.redhat.com [10.36.7.28]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r2DFwaDD028507; Wed, 13 Mar 2013 11:58:37 -0400 From: Alon Levy To: qemu-devel@nongnu.org Date: Wed, 13 Mar 2013 17:58:35 +0200 Message-Id: <1363190315-23956-1-git-send-email-alevy@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: kraxel@redhat.com Subject: [Qemu-devel] [PATCH] spice: (32 bit only) fix surface cmd tracking destruction X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org No change for 64 bit arches, but for 32 bit previously we zeroed half the surfaces cmd array, instead of all of it. Signed-off-by: Alon Levy Acked-by: Hans de Goede --- hw/qxl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index ef69348..4cbab45 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -226,7 +226,7 @@ static void qxl_spice_destroy_surfaces_complete(PCIQXLDevice *qxl) trace_qxl_spice_destroy_surfaces_complete(qxl->id); qemu_mutex_lock(&qxl->track_lock); memset(qxl->guest_surfaces.cmds, 0, - sizeof(qxl->guest_surfaces.cmds) * qxl->ssd.num_surfaces); + sizeof(qxl->guest_surfaces.cmds[0]) * qxl->ssd.num_surfaces); qxl->guest_surfaces.count = 0; qemu_mutex_unlock(&qxl->track_lock); }