From patchwork Fri Mar 8 14:52:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 226136 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 9A1DB2C0362 for ; Sat, 9 Mar 2013 01:52:54 +1100 (EST) Received: from localhost ([::1]:41923 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDyfE-0004oW-UR for incoming@patchwork.ozlabs.org; Fri, 08 Mar 2013 09:52:52 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDyer-0004jE-Qb for qemu-devel@nongnu.org; Fri, 08 Mar 2013 09:52:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDyel-0005pz-0R for qemu-devel@nongnu.org; Fri, 08 Mar 2013 09:52:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3904) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDyek-0005pr-QE for qemu-devel@nongnu.org; Fri, 08 Mar 2013 09:52:22 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r28EqKSO014041 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 8 Mar 2013 09:52:20 -0500 Received: from localhost (ovpn-112-36.ams2.redhat.com [10.36.112.36]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r28EqIfM019481; Fri, 8 Mar 2013 09:52:19 -0500 From: Stefan Hajnoczi To: Date: Fri, 8 Mar 2013 15:52:15 +0100 Message-Id: <1362754335-4381-1-git-send-email-stefanha@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: vilanova@ac.upc.edu, Stefan Hajnoczi Subject: [Qemu-devel] [PATCH] trace: rebuild generated-events.o when configuration changes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Make sure to rebuild generated-events.o when ./configure options change. This prevents linker errors when a stale generated-events.o gets linked with code compiled against fresh headers. For example, try building with ./configure --enable-trace-backend=stderr followed by ./configure --enable-trace-backend=dtrace. Signed-off-by: Stefan Hajnoczi --- trace/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trace/Makefile.objs b/trace/Makefile.objs index 156aa25..a043072 100644 --- a/trace/Makefile.objs +++ b/trace/Makefile.objs @@ -11,7 +11,7 @@ $(obj)/generated-events.h-timestamp: $(SRC_PATH)/trace-events < $< > $@," GEN $(patsubst %-timestamp,%,$@)") @cmp -s $@ $(patsubst %-timestamp,%,$@) || cp $@ $(patsubst %-timestamp,%,$@) -$(obj)/generated-events.c: $(obj)/generated-events.c-timestamp +$(obj)/generated-events.c: $(obj)/generated-events.c-timestamp $(BUILD_DIR)/config-host.mak $(obj)/generated-events.c-timestamp: $(SRC_PATH)/trace-events $(call quiet-command,$(TRACETOOL) \ --format=events-c \