From patchwork Sun Feb 10 22:12:44 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 219526 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id F41A22C02EA for ; Mon, 11 Feb 2013 09:22:05 +1100 (EST) Received: from localhost ([::1]:47480 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4fHf-0005Pd-Sw for incoming@patchwork.ozlabs.org; Sun, 10 Feb 2013 17:22:03 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4fHW-0005PQ-C9 for qemu-devel@nongnu.org; Sun, 10 Feb 2013 17:21:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U4fHU-0002s5-08 for qemu-devel@nongnu.org; Sun, 10 Feb 2013 17:21:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:19979) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4fAz-0001hl-R9 for qemu-devel@nongnu.org; Sun, 10 Feb 2013 17:15:10 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1AMDiNn021815 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 10 Feb 2013 17:13:44 -0500 Received: from localhost (ovpn-112-28.ams2.redhat.com [10.36.112.28]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r1AMDhsM001292; Sun, 10 Feb 2013 17:13:44 -0500 From: Stefan Hajnoczi To: Date: Sun, 10 Feb 2013 23:12:44 +0100 Message-Id: <1360534366-26723-2-git-send-email-stefanha@redhat.com> In-Reply-To: <1360534366-26723-1-git-send-email-stefanha@redhat.com> References: <1360534366-26723-1-git-send-email-stefanha@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Anthony Liguori , david.pravec@nethost.cz, Juan Quintela , Michael Roth , Stefan Hajnoczi , Paolo Bonzini Subject: [Qemu-devel] [PATCH for-1.4 stable v2 1/3] block-migration: improve "Unknown flags" error message X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Show the actual flags value and include "block migration" in the error message so it's clear where the error is coming from. Signed-off-by: Stefan Hajnoczi --- block-migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block-migration.c b/block-migration.c index 9ac7de6..573319a 100644 --- a/block-migration.c +++ b/block-migration.c @@ -695,7 +695,7 @@ static int block_load(QEMUFile *f, void *opaque, int version_id) (addr == 100) ? '\n' : '\r'); fflush(stdout); } else if (!(flags & BLK_MIG_FLAG_EOS)) { - fprintf(stderr, "Unknown flags\n"); + fprintf(stderr, "Unknown block migration flags: %#x\n", flags); return -EINVAL; } ret = qemu_file_get_error(f);