From patchwork Sat Feb 9 18:01:57 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 219416 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id D7BD42C0089 for ; Sun, 10 Feb 2013 05:08:54 +1100 (EST) Received: from localhost ([::1]:43422 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4EnN-0003N5-DV for incoming@patchwork.ozlabs.org; Sat, 09 Feb 2013 13:05:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:55802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4Emp-00021S-Af for qemu-devel@nongnu.org; Sat, 09 Feb 2013 13:04:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U4Emm-0004XY-Da for qemu-devel@nongnu.org; Sat, 09 Feb 2013 13:04:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:25177) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4Emm-0004XM-6j for qemu-devel@nongnu.org; Sat, 09 Feb 2013 13:04:24 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r19I4JqK022109 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 9 Feb 2013 13:04:19 -0500 Received: from localhost (ovpn-112-24.ams2.redhat.com [10.36.112.24]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r19I4HSe030935; Sat, 9 Feb 2013 13:04:18 -0500 From: Stefan Hajnoczi To: Date: Sat, 9 Feb 2013 19:01:57 +0100 Message-Id: <1360432919-1379-2-git-send-email-stefanha@redhat.com> In-Reply-To: <1360432919-1379-1-git-send-email-stefanha@redhat.com> References: <1360432919-1379-1-git-send-email-stefanha@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Anthony Liguori , david.pravec@nethost.cz, Juan Quintela , Michael Roth , Stefan Hajnoczi , Paolo Bonzini Subject: [Qemu-devel] [PATCH for-1.4 stable 1/3] block-migration: improve "Unknown flags" error message X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Show the actual flags value and include "block migration" in the error message so it's clear where the error is coming from. Signed-off-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Reviewed-by: Juan Quintela --- block-migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block-migration.c b/block-migration.c index 9ac7de6..573319a 100644 --- a/block-migration.c +++ b/block-migration.c @@ -695,7 +695,7 @@ static int block_load(QEMUFile *f, void *opaque, int version_id) (addr == 100) ? '\n' : '\r'); fflush(stdout); } else if (!(flags & BLK_MIG_FLAG_EOS)) { - fprintf(stderr, "Unknown flags\n"); + fprintf(stderr, "Unknown block migration flags: %#x\n", flags); return -EINVAL; } ret = qemu_file_get_error(f);