From patchwork Wed Jan 23 11:17:59 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wayne Xia X-Patchwork-Id: 214887 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 80C022C0087 for ; Wed, 23 Jan 2013 22:21:17 +1100 (EST) Received: from localhost ([::1]:49664 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TxyOJ-0007TC-HJ for incoming@patchwork.ozlabs.org; Wed, 23 Jan 2013 06:21:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45816) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TxyNz-0007F4-8x for qemu-devel@nongnu.org; Wed, 23 Jan 2013 06:20:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TxyNu-0007V4-5d for qemu-devel@nongnu.org; Wed, 23 Jan 2013 06:20:55 -0500 Received: from e28smtp02.in.ibm.com ([122.248.162.2]:34361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TxyNt-0007Ui-Gw for qemu-devel@nongnu.org; Wed, 23 Jan 2013 06:20:50 -0500 Received: from /spool/local by e28smtp02.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 23 Jan 2013 16:48:41 +0530 Received: from d28dlp02.in.ibm.com (9.184.220.127) by e28smtp02.in.ibm.com (192.168.1.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 23 Jan 2013 16:48:40 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 76902394004F for ; Wed, 23 Jan 2013 16:50:44 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r0NBKfEo48365790 for ; Wed, 23 Jan 2013 16:50:41 +0530 Received: from d28av02.in.ibm.com (loopback [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r0NBKhnq000326 for ; Wed, 23 Jan 2013 22:20:43 +1100 Received: from RH63Wenchao (wenchaox.cn.ibm.com [9.115.122.253]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id r0NBIFeV021779; Wed, 23 Jan 2013 22:20:39 +1100 From: Wenchao Xia To: qemu-devel@nongnu.org Date: Wed, 23 Jan 2013 19:17:59 +0800 Message-Id: <1358939887-22533-3-git-send-email-xiawenc@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1358939887-22533-1-git-send-email-xiawenc@linux.vnet.ibm.com> References: <1358939887-22533-1-git-send-email-xiawenc@linux.vnet.ibm.com> X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13012311-5816-0000-0000-000006609544 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 122.248.162.2 Cc: kwolf@redhat.com, pbonzini@redhat.com, aliguori@us.ibm.com, Wenchao Xia , stefanha@gmail.com Subject: [Qemu-devel] [PATCH V14 02/10] build: use check-clean in root Makefile X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Now root Makefile simply calls the command and do not care the details of it any more. $SUBDIR_CLEAN_RULES is used for the case that a sub-dir's Makefile is included by root Makefile, in which case 'clean' in subdir's Makefile will cause confict. So If sub-dir's Makefile want to be cleaned, it should extend $SUBDIR_CLEAN_RULES, just like tests/Makefile. Signed-off-by: Wenchao Xia --- Makefile | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 73adf42..69472b7 100644 --- a/Makefile +++ b/Makefile @@ -210,7 +210,7 @@ $(qga-obj-y) qemu-ga.o: $(QGALIB_GEN) qemu-ga$(EXESUF): $(qga-obj-y) libqemuutil.a libqemustub.a $(call LINK, $^) -clean: +clean: $(SUBDIR_CLEAN_RULES) # avoid old build problems by removing potentially incorrect old files rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h rm -f qemu-options.def @@ -226,7 +226,6 @@ clean: rm -f $(foreach f,$(GENERATED_SOURCES),$(f) $(f)-timestamp) rm -rf qapi-generated rm -rf qga/qapi-generated - $(MAKE) -C tests/tcg clean for d in $(ALL_SUBDIRS); do \ if test -d $$d; then $(MAKE) -C $$d $@ || exit 1; fi; \ rm -f $$d/qemu-options.def; \