From patchwork Fri Nov 16 11:04:17 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aurelien Jarno X-Patchwork-Id: 199549 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A93622C008F for ; Fri, 16 Nov 2012 22:39:30 +1100 (EST) Received: from localhost ([::1]:50566 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZJjV-0005rJ-LT for incoming@patchwork.ozlabs.org; Fri, 16 Nov 2012 06:05:13 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZJj2-0004zD-GX for qemu-devel@nongnu.org; Fri, 16 Nov 2012 06:04:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TZJiz-0006eh-DQ for qemu-devel@nongnu.org; Fri, 16 Nov 2012 06:04:44 -0500 Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:35603) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZJiz-0006cu-6O for qemu-devel@nongnu.org; Fri, 16 Nov 2012 06:04:41 -0500 Received: from wiportucb154.univ-lyon1.fr ([134.214.232.154] helo=ohm.aurel32.net) by hall.aurel32.net with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1TZJip-0001on-Vn; Fri, 16 Nov 2012 12:04:32 +0100 Received: from aurel32 by ohm.aurel32.net with local (Exim 4.80) (envelope-from ) id 1TZJij-00030p-St; Fri, 16 Nov 2012 12:04:25 +0100 From: Aurelien Jarno To: qemu-devel@nongnu.org Date: Fri, 16 Nov 2012 12:04:17 +0100 Message-Id: <1353063863-11446-2-git-send-email-aurelien@aurel32.net> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1353063863-11446-1-git-send-email-aurelien@aurel32.net> References: <1353063863-11446-1-git-send-email-aurelien@aurel32.net> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:470:1f15:c4f::1 Cc: Aurelien Jarno Subject: [Qemu-devel] [PATCH 1/7] target-mips: fix DSP loads with rd = 0 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org When rd is 0, which still need to do the actually load to possibly generate a TLB exception. Signed-off-by: Aurelien Jarno Reviewed-by: Eric Johnson --- target-mips/translate.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 01b48fa..c3e00c5 100644 --- a/target-mips/translate.c +++ b/target-mips/translate.c @@ -12631,11 +12631,6 @@ static void gen_mipsdsp_ld(CPUMIPSState *env, DisasContext *ctx, uint32_t opc, const char *opn = "ldx"; TCGv t0; - if (rd == 0) { - MIPS_DEBUG("NOP"); - return; - } - check_dsp(ctx); t0 = tcg_temp_new();