From patchwork Fri Sep 15 21:56:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 814411 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="vH6O/1vS"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xv8V31Gc2z9ryT for ; Sat, 16 Sep 2017 08:00:40 +1000 (AEST) Received: from localhost ([::1]:55139 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsyf3-0007om-TF for incoming@patchwork.ozlabs.org; Fri, 15 Sep 2017 18:00:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsyeY-0007ls-PZ for qemu-devel@nongnu.org; Fri, 15 Sep 2017 18:00:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsyeV-0005o0-PH for qemu-devel@nongnu.org; Fri, 15 Sep 2017 18:00:02 -0400 Received: from mail-bl2nam02on0070.outbound.protection.outlook.com ([104.47.38.70]:19558 helo=NAM02-BL2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dsyeV-0005nj-JN for qemu-devel@nongnu.org; Fri, 15 Sep 2017 17:59:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=jegL6PX50rMfX3F7i4LR3zPsH9HOg3DmUmoPMKblLgs=; b=vH6O/1vS6YXfXAnqoUKdQiHRatLtMThfl5rxizVMSLPr1/OIbjNs/FBV/WUcxd1XHOjp0mU2ZoSUPEHGoOfiDs6DCMXX/NbnyP33TquPNG+GWH3PhsyIbdzG/TuoMDJd4sbl864wmoru6mRisEVnZvbKtOWoDl3Dmo3h+i7ylwA= Received: from CY4PR02CA0048.namprd02.prod.outlook.com (10.175.57.162) by BN3PR02MB1127.namprd02.prod.outlook.com (10.162.168.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Fri, 15 Sep 2017 21:59:57 +0000 Received: from CY1NAM02FT040.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::204) by CY4PR02CA0048.outlook.office365.com (2603:10b6:903:117::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.8 via Frontend Transport; Fri, 15 Sep 2017 21:59:56 +0000 Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by CY1NAM02FT040.mail.protection.outlook.com (10.152.75.135) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.35.14 via Frontend Transport; Fri, 15 Sep 2017 21:59:55 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1dsyeQ-0005FD-4W; Fri, 15 Sep 2017 14:59:54 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1dsyeQ-000297-1y; Fri, 15 Sep 2017 14:59:54 -0700 Received: from xsj-pvapsmtp01 (xsj-pvapsmtp01.xilinx.com [149.199.38.66]) by xsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id v8FLxms7024057; Fri, 15 Sep 2017 14:59:48 -0700 Received: from [172.19.2.220] (helo=localhost.localdomain) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1dsyeK-000286-LL; Fri, 15 Sep 2017 14:59:48 -0700 From: Alistair Francis To: , Date: Fri, 15 Sep 2017 14:56:07 -0700 Message-ID: <134bcf2e2c0bb9160aa822ddfbc46d9bd51c4305.1505512474.git.alistair.francis@xilinx.com> X-Mailer: git-send-email 2.11.0 X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23330.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(376002)(346002)(2980300002)(438002)(199003)(189002)(8676002)(81156014)(63266004)(47776003)(8936002)(50226002)(5660300001)(9786002)(77096006)(54906002)(4326008)(39060400002)(118296001)(50986999)(305945005)(356003)(81166006)(6666003)(5003940100001)(36756003)(48376002)(575784001)(50466002)(36386004)(33646002)(478600001)(16586007)(2906002)(106466001)(316002)(189998001)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR02MB1127; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; PTR:unknown-60-83.xilinx.com; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; CY1NAM02FT040; 1:V+5mKEAO9OhVkGGJA0jQjNJrbbCRWzWXzNbmwdZv5I5GjHvzOOh4QhQ3voL5W7Fe5t/bEVS8H4Lp0EgmLneVxfVj36ymAF616xqwlseV4zvVCp5CB+3yXHcECudhPdC0 MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c0c31e82-e530-4172-ebee-08d4fc851a46 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(8251501002)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BN3PR02MB1127; X-Microsoft-Exchange-Diagnostics: 1; BN3PR02MB1127; 3:frm9arRRLUypXmEiR2DNakKx+9xwd8jv1kFwLMKX4bMP29VTgWnaKVpEKIAwJTnTt2ocabSsJD0N3k/Asbnx0eD9UZ8LKMkRRiaI1ejrlXk41ysx45TK/ryk+6lH0jJk+S8gWqgTbf5bAxH/NK733IfiAn+TWAI9UdqQBkfBktxlRg8mUXyM4bwcxoVP6ljS6clZ/bHgzUtyVDlJubaEvA2mT16F/an/gyr5ZBSMRAo96baUMpLRyclfo0JrHdCtG0DWthMngNogdme+Py0N67M2Cx7Svqe/6MCvFYV8gbBCRmMOAFQ6gWPy0S7VZq8nRs+7Tb0d/HoXDpNKvRyyiZ+pZ+H4jJL+GBfrmSLrjgY=; 25:gZWoikeIkUXx0w+4leiNS1zmHGP34W4jIoZwtcem2aCunv+EvFVRVk3VhVE8KQBKKNwSrIwIHKADMgO+mE2yLOUGGECA/BQQCXwXMog/DuLHQk24zx8x9mI+iIDnJ2AzZPjZ6H2OHMJXVMV1OrsjwqDZWK0vIQ8QwX/IgQ3Q1ICafSp+yNAF/jVUNB21CS3QSFJKN7OGQIUeqyhKLznY6AUKbxbtRvyoMntOFzgx7fVYUJXcPz3tpPJeNyDo/u9eIaYA571FSd4zMzSUw7+TfC9EhA3HZcdx3/yZQ6EntoX8qgLJNMa9HcNEXFBbdjuOp/ShjA7biHVt3aJSWu2RmQ== X-MS-TrafficTypeDiagnostic: BN3PR02MB1127: X-Microsoft-Exchange-Diagnostics: 1; BN3PR02MB1127; 31:PpQ7eCP8pgXHVOlbTT2c8Pruvd5msjDlZp54yxb96U87TkfS7OT42VTZUAuM9PhnKjup1PJlWqM0ktOIreRIiIhvguGyMjp0RDSxDz3NI/deWsdQu5+RcgwaEWlxvDxSy5Qsyvq7kfxhJ8gmvbly7x7OgfL4EmGtnKl4Ov5Dh+Sw7vAtwWUsNnBZByoqhZ+jog2hNfTyUgzkdmRH82gxSmSjKwaT/uFB/CRLZR7LfQg=; 20:98dwbFc1fAv+HjELYgroRweNnxS9ihD/wqYP/zfPC+06HtzFEPInBTOIlG1wq3yuX/QgZgm2x4L+QMUrDPi+DMOApOE3Mj+xVxQEZdc3B6v4v/nuYgTqih2uh4BSiqwTKvdKRjcxWk1+PJm+eZpERDK4odYQaFfIgOTy+YnocDqGSoHVt9Ogc03VHAoqxOp0sIMveYiusMq6Bp70k0eTz6jiVuZesH8+GI41tae+omeLQJ5eVOoatH8TpLCarvh6A3YmQrFtRyspKNkoJXvpC8a/1gU16BflGT+dp989hnbi016JTEvvVXKb8PImQBAEh4mqct+YE7f8w3JDiYUtN8H8bi0T1toWv3mYvIPiwfiZ8KPcpK6gMyC9vVVncLOb2Dp8F37MBdDA3LOUQ5qcXu4JlwpbMeAujM70lLriprTC8fpg1T45azrlwji0S3NnuVoJH0dsux/+V28+D6N+dbAvjy034Fc6yL3s6Ibe8dXBlBGLm+l/lH2GaSZuRPx0 X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(3002001)(93006095)(93004095)(6055026)(6041248)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN3PR02MB1127; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN3PR02MB1127; X-Microsoft-Exchange-Diagnostics: 1; BN3PR02MB1127; 4:4sJM/3s8Nja1meudEwLk9ug88t0rHeC6VPDBMR2klnCjtxkQsnDC3WBww4leWtn8BOmSHOknUdF8xGtwgLrq2WnV5c8JHt7d8DxF2wnXexrViV0v7xHm2b3TLP4JNpEQC5h7MjIt9j76KZHeCIf104Z/1hi0I5YLOQcnkU1lSGm3fpOEP7tFDwn4/QHxnzSX4cWb2UJAwRfR7QXGFJYZJ8BO62lZISDK7ieeQerTDmfP7M29Etzi/GEIb4bG22Y/PT/3Fy9pcwn+P/27S8Grnxa2V4wRLWKninXkCh8YBmI= X-Forefront-PRVS: 0431F981D8 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR02MB1127; 23:qPqGBoX2YudLlk5VweOfI6F7Lv83cPuTaOdxFI5u5?= Mv9lelNdQUN/v8R9s+E6x5SiUwjzme8iDcsRBnmJ8LTog0Cch4fL6+nMTmHRe0ZCAHFsqZkeD9CaqRs4LCYwlxwSDjoWGraQ1fYDH1L+HqgP2+YfHv6y2FxB8CRAv+6pSICPPZbtacljm0JGoSeDQiRxocBqUxbbWMBN7Q7C1m14SYZgxz7bC2pcfz2qCgRdWh8UBimgRdrk4ifXsEJGi7xU6hqrBGh7TB1BP7rSEKRd+qUqAHyehXq/l4T+twvPD5dFw5mQXNpWz7K7SCqe7TqBwGwUjTXpxAbLuCIzCjInR/jKcLkegClx8rMRG729jj7tvtqW2FFKKN8z5/E78Lh+5o4dbPYuUHjPGsqJQlvA+dBnye6DgiAK4nJzONpyEs64EbVZjKdCUgv1Fppcb8qBOcvoGvYxRQ+Zj6Dmh/wryFuaoIH+J4wl0ljJpXKfRqZPeik/t4KFM+eR1BWxr+w8qpFrsXo9DrzMJD05dV/D2ZvAjNo/96WDgzfo8bSZDOVyMbBkgP/cMt11T2KaVA6VKhX263or/xQap7l+snzsW7rv7V+sE64orY0gNF7iE/iQacmnmZ+OgJ7FiBJr/8Lb7blYxK5Nzm0P3o1PPXjCYXONpAnSOHYr8i1EMvD9+nbeSg1bV/t4WxuzqRHfyWJZ0sJiZ5s1/24yohzh05D3VO/D5KrWdxTpoDkvuSeVMux+akRe0TOt9PPqr5rFN2qLHhFH3Y2DZXzxmwGXGYILiDSzt8rFgLFvYLWOD0ERGLPORUs3nE7788CVMKjGasWF1XuZPRoOO72sgX6qrxzWsU3f683dHaI7v5j20HXRHJ9GBRqwA+ztBRX19wJiTL3vkbX+vNbtNxA8WLFj7YAcxJLuofug3Kyb2e/jTmdoSzaW7ug9Uy2caVpoMok3zm9vvRrz1UNBiioAhg9t+7AdA== X-Microsoft-Exchange-Diagnostics: 1; BN3PR02MB1127; 6:tKqGguvUMsnc2ADs9GQ2XpB9SAMZ95p1AKqnTB/OT0n5ljszilsARC09rb4OdZswtyYm4p/dTCON4tONMu41eVuvY5Kdu+7Ub8DOe+Nf63YXllYbRUzY7V8bzAveMIst22pAg6v0SvCAhcPPmOGfUHFaSHbR3L3iegiybAnR6yQzMWCz6umIBrl+9sHwG0aOM2b2uZkAvCsfQF5cezC9V7I2X4ciUcsxubbWRuy5UVmULftKB8YMegJwZ9dpgGxkPHXuZiy3fgGE/j6nehUT5xhxJV6xz8MF1L+qj6hiCA1bxHQQjJztpM9KZdlWaI7NbV1xJSNl5WNHHkrU6FqhQQ==; 5:eahACZem8Iz2KAoVntTUbOU+mjL9ConGgvkzUoqCBT9k4pZ+JaHLnyxgG2EGpm2h9uALvDMCFje/VAbeLubT7XpNtWvBlk1TjOaS+NXjrGTnN+7uAIkVb/R6uoKkztvcgbgH7ysK7lTQKbVsTOdbJQ==; 24:gRlP1loA5eLuty78p0ndEfgydDCxJP7eIH7hneDLdjzAOamay+IRzAOoF0xI2Hfc/RyA8s1sYfnXzJrxKBwZpVtXdq0XMS3QhGhOOpdOEXQ=; 7:d647DRR6mP3zwW93c73KId1P/MzMwqFlh8EikY/6eUpJhOJvhh9etuqD08Hgd2DyyQPgPL+skoyjkE5Qg0bDhFde26MT8MKydantIQKe1F7doYoysgxHbZ9Y0t5/fnvaRb5gtRvbYkcLJnj7PFf6lkbTn+ZzuQPL8X3SE9WYXwdjKyOMQ8x6qgLQIIv/EMW0L+aUpXpCj7+fy+itJ7l7PAp7eni2gW0dQUVdNTl195A= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2017 21:59:55.5287 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR02MB1127 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.38.70 Subject: [Qemu-devel] [PATCH v2 1/1] target/xtensa: Use the pre-defined MEMTXATTRS_UNSPECIFIED macro X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair23@gmail.com, alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Instead of using the hardcoded (MemTxAttrs){0} for no memory attributes let's use the already defined MEMTXATTRS_UNSPECIFIED macro instead. This is technically a change of behaviour as MEMTXATTRS_UNSPECIFIED sets the unspecified field to 1, but it doesn't look like anything is checking this field. Signed-off-by: Alistair Francis Acked-by: Max Filippov --- V2: - Update commit message to indicate the change in behaviour target/xtensa/op_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/xtensa/op_helper.c b/target/xtensa/op_helper.c index 519fbeddd6..3d990c0caa 100644 --- a/target/xtensa/op_helper.c +++ b/target/xtensa/op_helper.c @@ -1025,11 +1025,11 @@ void HELPER(ule_s)(CPUXtensaState *env, uint32_t br, float32 a, float32 b) uint32_t HELPER(rer)(CPUXtensaState *env, uint32_t addr) { return address_space_ldl(env->address_space_er, addr, - (MemTxAttrs){0}, NULL); + MEMTXATTRS_UNSPECIFIED, NULL); } void HELPER(wer)(CPUXtensaState *env, uint32_t data, uint32_t addr) { address_space_stl(env->address_space_er, addr, data, - (MemTxAttrs){0}, NULL); + MEMTXATTRS_UNSPECIFIED, NULL); }