From patchwork Tue Oct 9 20:30:51 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aurelien Jarno X-Patchwork-Id: 190433 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4741D2C0096 for ; Wed, 10 Oct 2012 07:31:30 +1100 (EST) Received: from localhost ([::1]:51500 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLgSd-0003od-1c for incoming@patchwork.ozlabs.org; Tue, 09 Oct 2012 16:31:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50632) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLgSG-0003b1-62 for qemu-devel@nongnu.org; Tue, 09 Oct 2012 16:31:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLgS8-0006EK-Pz for qemu-devel@nongnu.org; Tue, 09 Oct 2012 16:31:03 -0400 Received: from hall.aurel32.net ([88.191.126.93]:42142) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLgS8-0006Dv-Jt for qemu-devel@nongnu.org; Tue, 09 Oct 2012 16:30:56 -0400 Received: from [2001:470:d4ed:0:ea11:32ff:fea1:831a] (helo=ohm.aurel32.net) by hall.aurel32.net with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1TLgS7-00079x-82; Tue, 09 Oct 2012 22:30:55 +0200 Received: from aurel32 by ohm.aurel32.net with local (Exim 4.80) (envelope-from ) id 1TLgS5-0005p8-LF; Tue, 09 Oct 2012 22:30:53 +0200 From: Aurelien Jarno To: qemu-devel@nongnu.org Date: Tue, 9 Oct 2012 22:30:51 +0200 Message-Id: <1349814652-22325-5-git-send-email-aurelien@aurel32.net> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1349814652-22325-1-git-send-email-aurelien@aurel32.net> References: <1349814652-22325-1-git-send-email-aurelien@aurel32.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 88.191.126.93 Cc: Peter Maydell , Aurelien Jarno Subject: [Qemu-devel] [PATCH 4/5] tcg/arm: optimize tcg_out_goto_label X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org tcg_out_goto_label is only used inside a TB, so there is no reason for not using 24-bit branches even for COND_AL. Cc: Andrzej Zaborowski Cc: Peter Maydell Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 3191903..fafbd5d 100644 --- a/tcg/arm/tcg-target.c +++ b/tcg/arm/tcg-target.c @@ -959,14 +959,9 @@ static inline void tcg_out_goto_label(TCGContext *s, int cond, int label_index) { TCGLabel *l = &s->labels[label_index]; - if (l->has_value) + if (l->has_value) { tcg_out_goto(s, cond, l->u.value); - else if (cond == COND_AL) { - tcg_out_ld32_12(s, COND_AL, TCG_REG_PC, TCG_REG_PC, -4); - tcg_out_reloc(s, s->code_ptr, R_ARM_ABS32, label_index, 31337); - s->code_ptr += 4; } else { - /* Probably this should be preferred even for COND_AL... */ tcg_out_reloc(s, s->code_ptr, R_ARM_PC24, label_index, 31337); tcg_out_b_noaddr(s, cond); }