From patchwork Mon Oct 1 12:11:51 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Evgeny Voevodin X-Patchwork-Id: 188279 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id D8E792C00E3 for ; Mon, 1 Oct 2012 22:12:21 +1000 (EST) Received: from localhost ([::1]:36527 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIerD-00023q-CX for incoming@patchwork.ozlabs.org; Mon, 01 Oct 2012 08:12:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIer2-00023k-6B for qemu-devel@nongnu.org; Mon, 01 Oct 2012 08:12:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TIeqy-0002AJ-2O for qemu-devel@nongnu.org; Mon, 01 Oct 2012 08:12:08 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:18713) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIeqx-0002A9-Sq for qemu-devel@nongnu.org; Mon, 01 Oct 2012 08:12:03 -0400 Received: from eusync1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MB700CDKR8M9P80@mailout1.w1.samsung.com> for qemu-devel@nongnu.org; Mon, 01 Oct 2012 13:12:22 +0100 (BST) Received: from evvoevodinPC.rnd.samsung.ru ([106.109.8.9]) by eusync1.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0MB700M80R7UMY50@eusync1.samsung.com> for qemu-devel@nongnu.org; Mon, 01 Oct 2012 13:11:58 +0100 (BST) From: Evgeny Voevodin To: qemu-devel@nongnu.org Date: Mon, 01 Oct 2012 16:11:51 +0400 Message-id: <1349093511-28443-1-git-send-email-e.voevodin@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-TM-AS-MML: No X-detected-operating-system: by eggs.gnu.org: Solaris 10 (1203?) X-Received-From: 210.118.77.11 Cc: peter.maydell@linaro.org, kyungmin.park@samsung.com, e.gorelkina@samsung.com, Evgeny Voevodin , aliguori@us.ibm.com Subject: [Qemu-devel] [PATCH] hw/arm_gic.c: Fix improper DPRINTF output. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org s->cpu_enabled is a massive, so s->cpu_enabled ? "En" : "Dis" returns "En" always. We should use s->cpu_enabled[cpu] here. Signed-off-by: Evgeny Voevodin Reviewed-by: Peter Maydell --- hw/arm_gic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm_gic.c b/hw/arm_gic.c index 55871fa..4024dae 100644 --- a/hw/arm_gic.c +++ b/hw/arm_gic.c @@ -566,7 +566,7 @@ static void gic_cpu_write(gic_state *s, int cpu, int offset, uint32_t value) switch (offset) { case 0x00: /* Control */ s->cpu_enabled[cpu] = (value & 1); - DPRINTF("CPU %d %sabled\n", cpu, s->cpu_enabled ? "En" : "Dis"); + DPRINTF("CPU %d %sabled\n", cpu, s->cpu_enabled[cpu] ? "En" : "Dis"); break; case 0x04: /* Priority mask */ s->priority_mask[cpu] = (value & 0xff);