From patchwork Sat Sep 22 00:18:15 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 186009 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 62F982C008E for ; Sat, 22 Sep 2012 11:18:03 +1000 (EST) Received: from localhost ([::1]:40190 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFDRA-0006be-H4 for incoming@patchwork.ozlabs.org; Fri, 21 Sep 2012 20:19:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFDQV-0004gT-Pe for qemu-devel@nongnu.org; Fri, 21 Sep 2012 20:18:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TFDQU-00016i-TI for qemu-devel@nongnu.org; Fri, 21 Sep 2012 20:18:31 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:41851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFDQU-00015F-Ln for qemu-devel@nongnu.org; Fri, 21 Sep 2012 20:18:30 -0400 Received: by mail-pb0-f45.google.com with SMTP id rp12so8738004pbb.4 for ; Fri, 21 Sep 2012 17:18:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=1F7Plh63oUMdfXi6fOolKGhZ9vH0Ieab2oqGwf76AgE=; b=L+aYXhiCNG+W2eIVlRA6I7aTy7vxLslW21pknNDBNoPsjotrsdaFNA9Rp29tRIvPay BkIN3+RX63S9ezYCdzs+qBwkeaDGB+yiFi/SO23V1/OiWdL3tog8/+WY57h7vxxqPtGJ BUpb80E0Nd1s2u+PM/zi4dZ4TSp5m7UW38DTaTDeqDHz/tMwMZzWjRKPPEZfrelal/ql s5cHMJ9OpgMjvt35FFCD+33m5rt09P/O5I1nlG7ByEZqdS4ZVZXPgO2TKthbvM+Q0F+2 eJi5xi2W7nVJ/vtlX7EO5AA/fxZ5Q6LcGJa+7LIKbJQL39VGuAS9J/cP/+Nzj0waq7F4 NokQ== Received: by 10.68.242.42 with SMTP id wn10mr19142910pbc.105.1348273110403; Fri, 21 Sep 2012 17:18:30 -0700 (PDT) Received: from anchor.twiddle.home.com ([173.160.232.49]) by mx.google.com with ESMTPS id j9sm4837761pav.15.2012.09.21.17.18.29 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 21 Sep 2012 17:18:29 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 21 Sep 2012 17:18:15 -0700 Message-Id: <1348273096-1495-8-git-send-email-rth@twiddle.net> X-Mailer: git-send-email 1.7.11.4 In-Reply-To: <1348273096-1495-1-git-send-email-rth@twiddle.net> References: <1348273096-1495-1-git-send-email-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.160.45 Cc: aurelien@aurel32.net Subject: [Qemu-devel] [PATCH 7/8] tcg: Sanity check deposit inputs X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Given these are constants, checking once here means everything after can assume they're correct. Signed-off-by: Richard Henderson Reviewed-by: Aurelien Jarno --- tcg/tcg-op.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h index d2fb283..ecb1ac3 100644 --- a/tcg/tcg-op.h +++ b/tcg/tcg-op.h @@ -2081,6 +2081,10 @@ static inline void tcg_gen_deposit_i32(TCGv_i32 ret, TCGv_i32 arg1, uint32_t mask; TCGv_i32 t1; + tcg_debug_assert(ofs < 32); + tcg_debug_assert(len <= 32); + tcg_debug_assert(ofs + len <= 32); + if (ofs == 0 && len == 32) { tcg_gen_mov_i32(ret, arg2); return; @@ -2112,6 +2116,10 @@ static inline void tcg_gen_deposit_i64(TCGv_i64 ret, TCGv_i64 arg1, uint64_t mask; TCGv_i64 t1; + tcg_debug_assert(ofs < 64); + tcg_debug_assert(len <= 64); + tcg_debug_assert(ofs + len <= 64); + if (ofs == 0 && len == 64) { tcg_gen_mov_i64(ret, arg2); return;