From patchwork Fri Sep 7 13:16:29 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aurelien Jarno X-Patchwork-Id: 182370 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 927D72C009F for ; Fri, 7 Sep 2012 23:41:13 +1000 (EST) Received: from localhost ([::1]:48296 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9yRB-0004oN-AU for incoming@patchwork.ozlabs.org; Fri, 07 Sep 2012 09:17:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9yQS-0003Cj-Gy for qemu-devel@nongnu.org; Fri, 07 Sep 2012 09:16:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9yQI-0000s0-7b for qemu-devel@nongnu.org; Fri, 07 Sep 2012 09:16:48 -0400 Received: from hall.aurel32.net ([88.191.126.93]:37140) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9yQI-0000rn-0i for qemu-devel@nongnu.org; Fri, 07 Sep 2012 09:16:38 -0400 Received: from [46.27.142.81] (helo=ohm.aurel32.net) by hall.aurel32.net with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1T9yQG-00040m-Um; Fri, 07 Sep 2012 15:16:37 +0200 Received: from aurel32 by ohm.aurel32.net with local (Exim 4.80) (envelope-from ) id 1T9yQE-0006P5-73; Fri, 07 Sep 2012 15:16:34 +0200 From: Aurelien Jarno To: qemu-devel@nongnu.org Date: Fri, 7 Sep 2012 15:16:29 +0200 Message-Id: <1347023792-24045-7-git-send-email-aurelien@aurel32.net> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1347023792-24045-1-git-send-email-aurelien@aurel32.net> References: <1347023792-24045-1-git-send-email-aurelien@aurel32.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 88.191.126.93 Cc: Aurelien Jarno Subject: [Qemu-devel] [PATCH v2 6/9] tcg/optimize: swap brcond/setcond arguments when possible X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org brcond and setcond ops are not commutative, but it's easy to compute the new condition after swapping the arguments. Try to always put the constant argument in second position like for commutative ops, to help backends to generate better code. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- tcg/optimize.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index 1698ba3..7debc8a 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -318,6 +318,24 @@ static TCGArg *tcg_constant_folding(TCGContext *s, uint16_t *tcg_opc_ptr, args[2] = tmp; } break; + CASE_OP_32_64(brcond): + if (temps[args[0]].state == TCG_TEMP_CONST + && temps[args[1]].state != TCG_TEMP_CONST) { + tmp = args[0]; + args[0] = args[1]; + args[1] = tmp; + args[2] = tcg_swap_cond(args[2]); + } + break; + CASE_OP_32_64(setcond): + if (temps[args[1]].state == TCG_TEMP_CONST + && temps[args[2]].state != TCG_TEMP_CONST) { + tmp = args[1]; + args[1] = args[2]; + args[2] = tmp; + args[3] = tcg_swap_cond(args[3]); + } + break; default: break; }