From patchwork Wed Aug 22 17:15:37 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Filippov X-Patchwork-Id: 179351 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 1CAAA2C008E for ; Thu, 23 Aug 2012 03:16:31 +1000 (EST) Received: from localhost ([::1]:60900 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4EXc-00041K-28 for incoming@patchwork.ozlabs.org; Wed, 22 Aug 2012 13:16:28 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4EXV-000410-9o for qemu-devel@nongnu.org; Wed, 22 Aug 2012 13:16:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4EXT-0002is-RC for qemu-devel@nongnu.org; Wed, 22 Aug 2012 13:16:21 -0400 Received: from mail-lb0-f173.google.com ([209.85.217.173]:41239) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4EXT-0002ha-Jb for qemu-devel@nongnu.org; Wed, 22 Aug 2012 13:16:19 -0400 Received: by lbbgm13 with SMTP id gm13so699221lbb.4 for ; Wed, 22 Aug 2012 10:16:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=9pck8jL3pbfiaCEES35fkB9dd2SpLvmQtcOADTh4hdM=; b=SG6XyH4/AmNjYxbI/GqxSCXcUX/1bAiFXs0cpbKVCe0XXeLt3mNxnzL2ezFlRUwacS xYoRrA+buJdqW4agk6Qw3DrXa6khfXZcp+E2euTpSBQ5Pe4dck4HcbejJCSR7Kkv4q5A mO+xS4KEKcYO/G1elW3WtsOfKzJwYP8UNYMLU7twfr2dYbsayzxCz42NAplESoiRyVxx OF0WzeLsADmFvePKbVxTk2YMK2DoR/k8pB7iLyq1FFPuXP+rcLbDNP12zbLX7U6fa7uG OBSlp5hY/4avEW0jsP7h5ikWqQVBJ1DI+jxaKMCMc5rmWV0x/iZQZvLuVPlput+iT25U PZcA== Received: by 10.152.103.146 with SMTP id fw18mr22204189lab.30.1345655778393; Wed, 22 Aug 2012 10:16:18 -0700 (PDT) Received: from grizzly.metropolis ([188.134.19.124]) by mx.google.com with ESMTPS id lr17sm4959532lab.12.2012.08.22.10.16.16 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 22 Aug 2012 10:16:17 -0700 (PDT) From: Max Filippov To: qemu-devel@nongnu.org Date: Wed, 22 Aug 2012 21:15:37 +0400 Message-Id: <1345655737-2476-1-git-send-email-jcmvbkbc@gmail.com> X-Mailer: git-send-email 1.7.7.6 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.217.173 Cc: Max Filippov Subject: [Qemu-devel] [PATCH for-1.2] target-xtensa: return EINVAL for unimplemented simcalls X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This prevents guest from proceeding with uninitialised garbage returned from unimplemented simcalls. Signed-off-by: Max Filippov --- target-xtensa/xtensa-semi.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/target-xtensa/xtensa-semi.c b/target-xtensa/xtensa-semi.c index 1c8a19e..9afa99d 100644 --- a/target-xtensa/xtensa-semi.c +++ b/target-xtensa/xtensa-semi.c @@ -218,6 +218,8 @@ void HELPER(simcall)(CPUXtensaState *env) default: qemu_log("%s(%d): not implemented\n", __func__, regs[2]); + regs[2] = -1; + regs[3] = EINVAL; break; } }