From patchwork Tue Aug 21 10:51:31 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alon Levy X-Patchwork-Id: 179036 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 76FA72C008E for ; Tue, 21 Aug 2012 20:52:50 +1000 (EST) Received: from localhost ([::1]:35311 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3m4m-0002L1-ET for incoming@patchwork.ozlabs.org; Tue, 21 Aug 2012 06:52:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3m4Z-0002Ej-PP for qemu-devel@nongnu.org; Tue, 21 Aug 2012 06:52:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3m4T-00033m-5a for qemu-devel@nongnu.org; Tue, 21 Aug 2012 06:52:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60479) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3m4S-00033g-U8 for qemu-devel@nongnu.org; Tue, 21 Aug 2012 06:52:29 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7LAqRt6013932 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 21 Aug 2012 06:52:27 -0400 Received: from garlic.redhat.com (vpn-245-53.nrt.redhat.com [10.64.245.53]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7LAqNeM014357; Tue, 21 Aug 2012 06:52:25 -0400 From: Alon Levy To: qemu-devel@nongnu.org, kraxel@redhat.com Date: Tue, 21 Aug 2012 13:51:31 +0300 Message-Id: <1345546294-22144-1-git-send-email-alevy@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v11 1/4] qxl/update_area_io: guest_bug on invalid parameters X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Alon Levy --- v10->v11 fixed coding style: space before square bracket. fixed an old instance too. (Gerd) hw/qxl.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index c2dd3b4..6c48eb9 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1385,6 +1385,18 @@ async_common: QXLCookie *cookie = NULL; QXLRect update = d->ram->update_area; + if (d->ram->update_surface > NUM_SURFACES) { + qxl_set_guest_bug(d, "QXL_IO_UPDATE_AREA: invalid surface id %d\n", + d->ram->update_surface); + return; + } + if (update.left >= update.right || update.top >= update.bottom) { + qxl_set_guest_bug(d, + "QXL_IO_UPDATE_AREA: invalid area (%ux%u)x(%ux%u)\n", + update.left, update.top, update.right, update.bottom); + return; + } + if (async == QXL_ASYNC) { cookie = qxl_cookie_new(QXL_COOKIE_TYPE_IO, QXL_IO_UPDATE_AREA_ASYNC);