From patchwork Thu Aug 16 13:47:29 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 177992 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4AA1C2C0087 for ; Thu, 16 Aug 2012 23:46:37 +1000 (EST) Received: from localhost ([::1]:52921 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T20PD-0007I8-EL for incoming@patchwork.ozlabs.org; Thu, 16 Aug 2012 09:46:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48975) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T20P6-0007Gw-G6 for qemu-devel@nongnu.org; Thu, 16 Aug 2012 09:46:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T20P5-0004T6-D4 for qemu-devel@nongnu.org; Thu, 16 Aug 2012 09:46:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T20P5-0004T0-5g for qemu-devel@nongnu.org; Thu, 16 Aug 2012 09:46:27 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7GDkQKR005143 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 16 Aug 2012 09:46:26 -0400 Received: from shalem.localdomain.com (vpn1-6-196.ams2.redhat.com [10.36.6.196]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7GDkP1g024823; Thu, 16 Aug 2012 09:46:25 -0400 From: Hans de Goede To: Gerd Hoffmann Date: Thu, 16 Aug 2012 15:47:29 +0200 Message-Id: <1345124849-18722-1-git-send-email-hdegoede@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: Hans de Goede , qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH] ehci: Remove unnecessary ehci_flush_qh call X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org ehci_qh_do_overlay() already calls ehci_flush_qh() before it returns, calling it twice is useless. Signed-off-by: Hans de Goede --- hw/usb/hcd-ehci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 8b94b17..41d663d 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -1956,7 +1956,6 @@ static int ehci_state_fetchqtd(EHCIQueue *q) } if (p != NULL) { ehci_qh_do_overlay(q); - ehci_flush_qh(q); if (p->async == EHCI_ASYNC_INFLIGHT) { ehci_set_state(q->ehci, q->async, EST_HORIZONTALQH); } else {