From patchwork Fri Jul 13 16:53:21 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 170931 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B09532C02FB for ; Sat, 14 Jul 2012 02:53:36 +1000 (EST) Received: from localhost ([::1]:35544 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Spj7W-0001dK-RS for incoming@patchwork.ozlabs.org; Fri, 13 Jul 2012 12:53:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Spj6z-0000A3-7B for qemu-devel@nongnu.org; Fri, 13 Jul 2012 12:53:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Spj6y-0006iJ-7W for qemu-devel@nongnu.org; Fri, 13 Jul 2012 12:53:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Spj6x-0006i8-QJ for qemu-devel@nongnu.org; Fri, 13 Jul 2012 12:53:00 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6DGqxGZ009811 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 13 Jul 2012 12:52:59 -0400 Received: from localhost ([10.3.113.3]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6DGqwoW017289; Fri, 13 Jul 2012 12:52:58 -0400 From: Luiz Capitulino To: aliguori@us.ibm.com Date: Fri, 13 Jul 2012 13:53:21 -0300 Message-Id: <1342198402-20666-3-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1342198402-20666-1-git-send-email-lcapitulino@redhat.com> References: <1342198402-20666-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH 2/3] qapi: input_type_enum(): fix error message X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The enum string is pointed to by 'enum_str' not 'name'. This bug causes the error message to be: { "error": { "class": "InvalidParameter", "desc": "Invalid parameter 'null'", "data": { "name": "null" } } } Signed-off-by: Luiz Capitulino Reviewed-by: Amos Kong --- qapi/qapi-visit-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/qapi-visit-core.c b/qapi/qapi-visit-core.c index ffffbf7..705eca9 100644 --- a/qapi/qapi-visit-core.c +++ b/qapi/qapi-visit-core.c @@ -298,7 +298,7 @@ void input_type_enum(Visitor *v, int *obj, const char *strings[], } if (strings[value] == NULL) { - error_set(errp, QERR_INVALID_PARAMETER, name ? name : "null"); + error_set(errp, QERR_INVALID_PARAMETER, enum_str); g_free(enum_str); return; }