From patchwork Wed Jun 27 03:55:11 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Evgeny Voevodin X-Patchwork-Id: 167496 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 71848B6FCA for ; Wed, 27 Jun 2012 13:55:48 +1000 (EST) Received: from localhost ([::1]:60191 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjjM2-0005gw-AW for incoming@patchwork.ozlabs.org; Tue, 26 Jun 2012 23:55:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjjLk-0005Sz-Fz for qemu-devel@nongnu.org; Tue, 26 Jun 2012 23:55:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SjjLg-00067S-D5 for qemu-devel@nongnu.org; Tue, 26 Jun 2012 23:55:28 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:27212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjjLg-000607-7R for qemu-devel@nongnu.org; Tue, 26 Jun 2012 23:55:24 -0400 Received: from eusync2.samsung.com (mailout3.w1.samsung.com [210.118.77.13]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M69005ZAC987V20@mailout3.w1.samsung.com> for qemu-devel@nongnu.org; Wed, 27 Jun 2012 04:55:56 +0100 (BST) Received: from evvoevodinPC.rnd.samsung.ru ([106.109.8.38]) by eusync2.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0M6900BXZC807K00@eusync2.samsung.com> for qemu-devel@nongnu.org; Wed, 27 Jun 2012 04:55:20 +0100 (BST) From: Evgeny Voevodin To: qemu-devel@nongnu.org Date: Wed, 27 Jun 2012 07:55:11 +0400 Message-id: <1340769311-19692-4-git-send-email-e.voevodin@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1340769311-19692-1-git-send-email-e.voevodin@samsung.com> References: <1340769311-19692-1-git-send-email-e.voevodin@samsung.com> X-TM-AS-MML: No X-detected-operating-system: by eggs.gnu.org: Solaris 10 (1203?) X-Received-From: 210.118.77.13 Cc: m.shcherbina@samsung.com, o.ogurtsov@samsung.com, i.mitsyanko@samsung.com, Evgeny Voevodin , peter.maydell@linaro.org, kyungmin.park@samsung.com, d.solodkiy@samsung.com, s.vorobiov@samsung.com, m.kozlov@samsung.com Subject: [Qemu-devel] [PATCH 3/3] hw/exynos4210.c: Fix misleading initialization of IROM mirror X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org We want to mirror whole IROM and should pass zero instead of EXYNOS4210_IROM_BASE_ADDR (though it equals to zero too) since memory_region_init_alias takes an offset within an original region as an argument. Signed-off-by: Evgeny Voevodin Reviewed-by: Peter Maydell --- hw/exynos4210.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/exynos4210.c b/hw/exynos4210.c index 9c20b3f..80a00b9 100644 --- a/hw/exynos4210.c +++ b/hw/exynos4210.c @@ -216,7 +216,7 @@ Exynos4210State *exynos4210_init(MemoryRegion *system_mem, /* mirror of iROM */ memory_region_init_alias(&s->irom_alias_mem, "exynos4210.irom_alias", &s->irom_mem, - EXYNOS4210_IROM_BASE_ADDR, + 0, EXYNOS4210_IROM_SIZE); memory_region_set_readonly(&s->irom_alias_mem, true); memory_region_add_subregion(system_mem, EXYNOS4210_IROM_MIRROR_BASE_ADDR,