From patchwork Fri Jun 22 07:22:24 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Evgeny Voevodin X-Patchwork-Id: 166538 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 11117B6F6E for ; Fri, 22 Jun 2012 17:22:56 +1000 (EST) Received: from localhost ([::1]:51726 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShyCj-0000BU-Vw for incoming@patchwork.ozlabs.org; Fri, 22 Jun 2012 03:22:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48395) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShyCY-0000B8-Fc for qemu-devel@nongnu.org; Fri, 22 Jun 2012 03:22:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ShyCU-0004e4-5P for qemu-devel@nongnu.org; Fri, 22 Jun 2012 03:22:42 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:28313) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShyCT-0004dX-Vs for qemu-devel@nongnu.org; Fri, 22 Jun 2012 03:22:38 -0400 Received: from eusync4.samsung.com (mailout3.w1.samsung.com [210.118.77.13]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M6000EZSCIJEU10@mailout3.w1.samsung.com> for qemu-devel@nongnu.org; Fri, 22 Jun 2012 08:23:07 +0100 (BST) Received: from evvoevodinPC.rnd.samsung.ru ([106.109.8.38]) by eusync4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0M60007F8CHE4X30@eusync4.samsung.com> for qemu-devel@nongnu.org; Fri, 22 Jun 2012 08:22:31 +0100 (BST) From: Evgeny Voevodin To: qemu-devel@nongnu.org Date: Fri, 22 Jun 2012 11:22:24 +0400 Message-id: <1340349744-23920-1-git-send-email-e.voevodin@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-TM-AS-MML: No X-detected-operating-system: by eggs.gnu.org: Solaris 10 (1203?) X-Received-From: 210.118.77.13 Cc: m.shcherbina@samsung.com, o.ogurtsov@samsung.com, i.mitsyanko@samsung.com, Evgeny Voevodin , peter.maydell@linaro.org, kyungmin.park@samsung.com, d.solodkiy@samsung.com, s.vorobiov@samsung.com, m.kozlov@samsung.com Subject: [Qemu-devel] [PATCH] ARM: hw/exynos4210_mct.c: Fix a bug which hangs Linux kernel. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Stanislav Vorobiov After some long period of time Linux kernel hanged due to ptimer_get_count may return 0 before timer interrupt occurs, thus, causing FRC to jump back in time Signed-off-by: Evgeny Voevodin --- hw/exynos4210_mct.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/exynos4210_mct.c b/hw/exynos4210_mct.c index 7474fcf..7a22b1f 100644 --- a/hw/exynos4210_mct.c +++ b/hw/exynos4210_mct.c @@ -376,10 +376,6 @@ static uint64_t exynos4210_gfrc_get_count(Exynos4210MCTGT *s) { uint64_t count = 0; count = ptimer_get_count(s->ptimer_frc); - if (!count) { - /* Timer event was generated and s->reg.cnt holds adequate value */ - return s->reg.cnt; - } count = s->count - count; return s->reg.cnt + count; }