From patchwork Fri Jun 15 17:10:01 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 165213 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 893DCB7095 for ; Sat, 16 Jun 2012 04:09:16 +1000 (EST) Received: from localhost ([::1]:46787 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sfa2T-0001K4-Py for incoming@patchwork.ozlabs.org; Fri, 15 Jun 2012 13:10:25 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sfa23-000052-Bk for qemu-devel@nongnu.org; Fri, 15 Jun 2012 13:10:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sfa21-0002Tn-FP for qemu-devel@nongnu.org; Fri, 15 Jun 2012 13:09:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15515) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sfa21-0002TP-73 for qemu-devel@nongnu.org; Fri, 15 Jun 2012 13:09:57 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5FH9t3r011346 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 15 Jun 2012 13:09:55 -0400 Received: from localhost (ovpn-116-38.ams2.redhat.com [10.36.116.38]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q5FH9rXu028155; Fri, 15 Jun 2012 13:09:54 -0400 From: Luiz Capitulino To: aliguori@us.ibm.com Date: Fri, 15 Jun 2012 14:10:01 -0300 Message-Id: <1339780205-3447-5-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1339780205-3447-1-git-send-email-lcapitulino@redhat.com> References: <1339780205-3447-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: Stefan Weil , qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH 4/8] monitor: Fix memory leak with readline completion X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Stefan Weil Each string which is shown during readline completion in the QEMU monitor is allocated dynamically but currently never deallocated. Add the missing loop which calls g_free for the allocated strings. Signed-off-by: Stefan Weil Reviewed-by: Stefan Hajnoczi Signed-off-by: Luiz Capitulino --- readline.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/readline.c b/readline.c index a6c0039..540cd8a 100644 --- a/readline.c +++ b/readline.c @@ -337,6 +337,9 @@ static void readline_completion(ReadLineState *rs) } readline_show_prompt(rs); } + for (i = 0; i < rs->nb_completions; i++) { + g_free(rs->completions[i]); + } } /* return true if command handled */