From patchwork Thu May 24 09:38:14 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alon Levy X-Patchwork-Id: 161111 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 35266B6FCC for ; Thu, 24 May 2012 19:59:24 +1000 (EST) Received: from localhost ([::1]:59136 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXUVm-0004Nc-3M for incoming@patchwork.ozlabs.org; Thu, 24 May 2012 05:39:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXUV3-0002Zd-GK for qemu-devel@nongnu.org; Thu, 24 May 2012 05:38:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXUUv-0007r1-UC for qemu-devel@nongnu.org; Thu, 24 May 2012 05:38:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXUUv-0007qU-N1 for qemu-devel@nongnu.org; Thu, 24 May 2012 05:38:21 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4O9cKin031654 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 24 May 2012 05:38:20 -0400 Received: from garlic.tlv.redhat.com (spice-ovirt.tlv.redhat.com [10.35.4.71]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4O9cEj1028735; Thu, 24 May 2012 05:38:19 -0400 From: Alon Levy To: qemu-devel@nongnu.org, kraxel@redhat.com Date: Thu, 24 May 2012 12:38:14 +0300 Message-Id: <1337852294-12224-4-git-send-email-alevy@redhat.com> In-Reply-To: <1337852294-12224-1-git-send-email-alevy@redhat.com> References: <4FBDF65F.8070609@redhat.com> <1337852294-12224-1-git-send-email-alevy@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 4/4] qxl: stop dirty loging when not in vga mode X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Tested with linux guest. Not sure how to check actual performance affect of this. Checked with the previously send traceevent that the kvm ioctl to start/stop dirty logging is being called. (KVM_SET_USER_MEMORY_REGION). Signed-off-by: Alon Levy --- hw/qxl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index e28c482..05ff176 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -932,6 +932,7 @@ static void qxl_enter_vga_mode(PCIQXLDevice *d) qemu_spice_create_host_primary(&d->ssd); d->mode = QXL_MODE_VGA; memset(&d->ssd.dirty, 0, sizeof(d->ssd.dirty)); + vga_dirty_log_start(&d->vga); } static void qxl_exit_vga_mode(PCIQXLDevice *d) @@ -940,6 +941,7 @@ static void qxl_exit_vga_mode(PCIQXLDevice *d) return; } trace_qxl_exit_vga_mode(d->id); + vga_dirty_log_stop(&d->vga); qxl_destroy_primary(d, QXL_SYNC); }