| Message ID | 1337852294-12224-1-git-send-email-alevy@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Thu, May 24, 2012 at 12:38:11PM +0300, Alon Levy wrote: > We can't initialize QXLDevSurfaceCreate field by field because it has a > pa hole, and so 4 bytes remain uninitialized when building on x86-64, so > just memset. This was supposed to be in reply to "<4FBDF65F.8070609@redhat.com>", rebased on just pulled master, so should apply cleanly. > > Signed-off-by: Alon Levy <alevy@redhat.com> > --- > ui/spice-display.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ui/spice-display.c b/ui/spice-display.c > index 5418eb3..3e8f0b3 100644 > --- a/ui/spice-display.c > +++ b/ui/spice-display.c > @@ -244,6 +244,8 @@ void qemu_spice_create_host_primary(SimpleSpiceDisplay *ssd) > { > QXLDevSurfaceCreate surface; > > + memset(&surface, 0, sizeof(surface)); > + > dprint(1, "%s: %dx%d\n", __FUNCTION__, > ds_get_width(ssd->ds), ds_get_height(ssd->ds)); > > -- > 1.7.10.1 > >
diff --git a/ui/spice-display.c b/ui/spice-display.c index 5418eb3..3e8f0b3 100644 --- a/ui/spice-display.c +++ b/ui/spice-display.c @@ -244,6 +244,8 @@ void qemu_spice_create_host_primary(SimpleSpiceDisplay *ssd) { QXLDevSurfaceCreate surface; + memset(&surface, 0, sizeof(surface)); + dprint(1, "%s: %dx%d\n", __FUNCTION__, ds_get_width(ssd->ds), ds_get_height(ssd->ds));
We can't initialize QXLDevSurfaceCreate field by field because it has a pa hole, and so 4 bytes remain uninitialized when building on x86-64, so just memset. Signed-off-by: Alon Levy <alevy@redhat.com> --- ui/spice-display.c | 2 ++ 1 file changed, 2 insertions(+)