From patchwork Tue May 22 15:29:58 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alon Levy X-Patchwork-Id: 160665 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A3258B6FA1 for ; Wed, 23 May 2012 01:30:39 +1000 (EST) Received: from localhost ([::1]:38156 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWr2j-0003Na-Hm for incoming@patchwork.ozlabs.org; Tue, 22 May 2012 11:30:37 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWr2Q-0002n1-8a for qemu-devel@nongnu.org; Tue, 22 May 2012 11:30:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SWr2D-0003Ne-C6 for qemu-devel@nongnu.org; Tue, 22 May 2012 11:30:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31986) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWr2D-0003Hs-4P for qemu-devel@nongnu.org; Tue, 22 May 2012 11:30:05 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4MFU2J4000941 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 22 May 2012 11:30:03 -0400 Received: from garlic.tlv.redhat.com (dhcp-4-119.tlv.redhat.com [10.35.4.119]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4MFU0YC027784; Tue, 22 May 2012 11:30:01 -0400 From: Alon Levy To: qemu-devel@nongnu.org, kraxel@redhat.com Date: Tue, 22 May 2012 18:29:58 +0300 Message-Id: <1337700600-23870-1-git-send-email-alevy@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org We can't initialize QXLDevSurfaceCreate field by field because it has a pa hole, and so 4 bytes remain uninitialized when building on x86-64, so just memset. Signed-off-by: Alon Levy --- ui/spice-display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/spice-display.c b/ui/spice-display.c index 5418eb3..3e8f0b3 100644 --- a/ui/spice-display.c +++ b/ui/spice-display.c @@ -244,6 +244,8 @@ void qemu_spice_create_host_primary(SimpleSpiceDisplay *ssd) { QXLDevSurfaceCreate surface; + memset(&surface, 0, sizeof(surface)); + dprint(1, "%s: %dx%d\n", __FUNCTION__, ds_get_width(ssd->ds), ds_get_height(ssd->ds));