From patchwork Fri May 4 20:20:19 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 156989 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A6945B707A for ; Sat, 5 May 2012 06:55:24 +1000 (EST) Received: from localhost ([::1]:43043 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQP00-0005ur-4T for incoming@patchwork.ozlabs.org; Fri, 04 May 2012 16:21:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQOzi-0005AN-Gv for qemu-devel@nongnu.org; Fri, 04 May 2012 16:20:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SQOzg-0006OA-NZ for qemu-devel@nongnu.org; Fri, 04 May 2012 16:20:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52168) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQOzg-0006Nr-Fe for qemu-devel@nongnu.org; Fri, 04 May 2012 16:20:48 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q44KKNcR011623 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 4 May 2012 16:20:23 -0400 Received: from localhost (ovpn-116-75.ams2.redhat.com [10.36.116.75]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q44KKKMa015112; Fri, 4 May 2012 16:20:22 -0400 From: Luiz Capitulino To: qemu-devel@nongnu.org Date: Fri, 4 May 2012 17:20:19 -0300 Message-Id: <1336162822-13161-4-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1336162822-13161-1-git-send-email-lcapitulino@redhat.com> References: <1336162822-13161-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: pbonzini@redhat.com, mdroth@linux.vnet.ibm.com, mprivozn@redhat.com Subject: [Qemu-devel] [PATCH 3/6] qemu-ga: guest-shutdown: don't emit a success response X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Today, qemu-ga may not be able to emit a success response when guest-shutdown completes. This happens because the VM may vanish before qemu-ga is able to emit a response. This semantic is a bit confusing, as it's not clear for clients if they should wait for a response or how they should check for success. This commit solves that problem by changing guest-shutdown to never emit a success response and suggests in the documentation what clients could do to check for success. Signed-off-by: Luiz Capitulino Reviewed-by: Michael Roth --- qapi-schema-guest.json | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json index d7a073e..0aa9f91 100644 --- a/qapi-schema-guest.json +++ b/qapi-schema-guest.json @@ -131,11 +131,13 @@ # # @mode: #optional "halt", "powerdown" (default), or "reboot" # -# Returns: Nothing on success +# Returns: This command does NOT return a response on success. Success +# condition is indicated by the VM exiting with a zero exit status. # # Since: 0.15.0 ## -{ 'command': 'guest-shutdown', 'data': { '*mode': 'str' } } +{ 'command': 'guest-shutdown', 'data': { '*mode': 'str' }, + 'success-response': 'no' } ## # @guest-file-open: