From patchwork Thu Apr 26 21:10:05 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 155328 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C5B87B6FB9 for ; Fri, 27 Apr 2012 07:10:20 +1000 (EST) Received: from localhost ([::1]:58748 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SNVxC-0007oI-HA for incoming@patchwork.ozlabs.org; Thu, 26 Apr 2012 17:10:18 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SNVww-0007jp-OC for qemu-devel@nongnu.org; Thu, 26 Apr 2012 17:10:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SNVwu-00039U-EA for qemu-devel@nongnu.org; Thu, 26 Apr 2012 17:10:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SNVwu-00039A-5z for qemu-devel@nongnu.org; Thu, 26 Apr 2012 17:10:00 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3QL9wFn025170 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 26 Apr 2012 17:09:58 -0400 Received: from localhost (ovpn-113-104.phx2.redhat.com [10.3.113.104]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3QL9v5a022704; Thu, 26 Apr 2012 17:09:58 -0400 From: Luiz Capitulino To: qemu-devel@nongnu.org Date: Thu, 26 Apr 2012 18:10:05 -0300 Message-Id: <1335474606-22889-2-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1335474606-22889-1-git-send-email-lcapitulino@redhat.com> References: <1335474606-22889-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: amit.shah@redhat.com, qzhang@redhat.com, armbru@redhat.com Subject: [Qemu-devel] [PATCH 1/2] hmp: expr_unary(): check for overflow in strtoul() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org It's not checked currently, so something like: (qemu) balloon -100000000000001111114334234 (qemu) Will just "work" (in this case the balloon command will get a random value). Fix it by checking if strtout() overflowed. Signed-off-by: Luiz Capitulino --- monitor.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/monitor.c b/monitor.c index 8946a10..6178f48 100644 --- a/monitor.c +++ b/monitor.c @@ -3122,8 +3122,14 @@ static int64_t expr_unary(Monitor *mon) default: #if TARGET_PHYS_ADDR_BITS > 32 n = strtoull(pch, &p, 0); + if (n == ULLONG_MAX && errno == ERANGE) { + expr_error(mon, "error: too long number"); + } #else n = strtoul(pch, &p, 0); + if (n == ULONG_MAX && errno == ERANGE) { + expr_error(mon, "error: too long number"); + } #endif if (pch == p) { expr_error(mon, "invalid char in expression");