From patchwork Wed Apr 25 09:13:23 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alon Levy X-Patchwork-Id: 154841 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E0393B6FBD for ; Wed, 25 Apr 2012 19:15:11 +1000 (EST) Received: from localhost ([::1]:60088 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMyJZ-0002Qy-Nw for incoming@patchwork.ozlabs.org; Wed, 25 Apr 2012 05:15:09 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMyJL-00029r-01 for qemu-devel@nongnu.org; Wed, 25 Apr 2012 05:14:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SMyJF-0002YC-GD for qemu-devel@nongnu.org; Wed, 25 Apr 2012 05:14:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61305) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMyJF-0002WE-8d for qemu-devel@nongnu.org; Wed, 25 Apr 2012 05:14:49 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3P9ElWB004127 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 25 Apr 2012 05:14:48 -0400 Received: from garlic.redhat.com (vpn-202-70.tlv.redhat.com [10.35.202.70]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q3P9DVR0024620; Wed, 25 Apr 2012 05:14:42 -0400 From: Alon Levy To: qemu-devel@nongnu.org, kraxel@redhat.com Date: Wed, 25 Apr 2012 12:13:23 +0300 Message-Id: <1335345205-8908-7-git-send-email-alevy@redhat.com> In-Reply-To: <1335345205-8908-1-git-send-email-alevy@redhat.com> References: <4F967EEA.6000302@redhat.com> <1335345205-8908-1-git-send-email-alevy@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 7/9] qxl: interface_notify_update: remove guest trigerrable abort X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Alon Levy --- hw/qxl.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 6e7232c..44ee495 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -768,8 +768,13 @@ static int interface_req_cursor_notification(QXLInstance *sin) /* called from spice server thread context */ static void interface_notify_update(QXLInstance *sin, uint32_t update_id) { - fprintf(stderr, "%s: abort()\n", __FUNCTION__); - abort(); + /* + * Called by spice-server as a result of a QXL_CMD_UPDATE which is not in + * use by xf86-video-qxl and is defined out in the qxl windows driver. + * Probably was at some earlier version that is prior to git start (2009), + * and is still guest trigerrable. + */ + fprintf(stderr, "%s: deprecated\n", __func__); } /* called from spice server thread context only */