From patchwork Fri Mar 30 17:16:36 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 149693 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 38A9FB6FA3 for ; Sat, 31 Mar 2012 04:20:20 +1100 (EST) Received: from localhost ([::1]:35467 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDfUo-0003B8-1H for incoming@patchwork.ozlabs.org; Fri, 30 Mar 2012 13:20:18 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDfUT-0002M9-8R for qemu-devel@nongnu.org; Fri, 30 Mar 2012 13:19:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDfUR-00062x-Ej for qemu-devel@nongnu.org; Fri, 30 Mar 2012 13:19:56 -0400 Received: from mail-qc0-f173.google.com ([209.85.216.173]:46041) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDfUR-00062I-8N for qemu-devel@nongnu.org; Fri, 30 Mar 2012 13:19:55 -0400 Received: by qcsc20 with SMTP id c20so505344qcs.4 for ; Fri, 30 Mar 2012 10:19:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=D2eBqyrbshllmdoD7olAArh7pTZ66xRs02NlEZIcNZs=; b=zYl//RS84AiheYNEKQJ8n+QFjdoZnZ5WQq6+A+8FbtizHQJ9Fy1DP9OcRV4sGjoTFy JDmJxQYyRY4tJsuuhtTHaMzQmKVKiw3DG0bBZMuFxOK+CZLo5zMie6toDvbHTOWbLE/+ UxEVT6w4T2GfOnSMHUDazQPCEOhrFml+y9o5BJX0WrgWFN4jE342sjbf0AbYHn63ool4 O+zzov7IM39DVfthnrnixrgmT9WSQMmY3cPzzlavl7Rys03CJouLp1w/TUlTmxqfwxDZ LJ0hQec1z5yxwjvGVUsvO9YnAoOMvXd1Txj56W0MQ47qw6ey1927dxi7WBxhxwiTfBAA 4XRw== Received: by 10.224.195.5 with SMTP id ea5mr6685009qab.30.1333127993634; Fri, 30 Mar 2012 10:19:53 -0700 (PDT) Received: from pebble.com ([200.7.43.190]) by mx.google.com with ESMTPS id cv8sm19272326qab.12.2012.03.30.10.19.52 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 30 Mar 2012 10:19:53 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 30 Mar 2012 13:16:36 -0400 Message-Id: <1333127797-8133-2-git-send-email-rth@twiddle.net> X-Mailer: git-send-email 1.7.7.6 In-Reply-To: <1333127797-8133-1-git-send-email-rth@twiddle.net> References: <1333127797-8133-1-git-send-email-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.216.173 Cc: aurelien@aurel32.net Subject: [Qemu-devel] [PATCH 1/2] target-mips: Streamline indexed cp1 memory addressing. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org We've already eliminated both base and index being zero. --- target-mips/translate.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index a663b74..300d95e 100644 --- a/target-mips/translate.c +++ b/target-mips/translate.c @@ -7742,8 +7742,7 @@ static void gen_flt3_ldst (DisasContext *ctx, uint32_t opc, } else if (index == 0) { gen_load_gpr(t0, base); } else { - gen_load_gpr(t0, index); - gen_op_addr_add(ctx, t0, cpu_gpr[base], t0); + gen_op_addr_add(ctx, t0, cpu_gpr[base], cpu_gpr[index]); } /* Don't do NOP if destination is zero: we must perform the actual memory access. */