From patchwork Fri Mar 30 07:53:53 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 149581 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id AD16CB6F98 for ; Fri, 30 Mar 2012 18:52:11 +1100 (EST) Received: from localhost ([::1]:47041 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDWcz-0004d0-35 for incoming@patchwork.ozlabs.org; Fri, 30 Mar 2012 03:52:09 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDWcq-0004bz-ES for qemu-devel@nongnu.org; Fri, 30 Mar 2012 03:52:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDWch-0004eb-OM for qemu-devel@nongnu.org; Fri, 30 Mar 2012 03:52:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40889) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDWch-0004eP-GH for qemu-devel@nongnu.org; Fri, 30 Mar 2012 03:51:51 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2U7pnX3005709 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 30 Mar 2012 03:51:49 -0400 Received: from shalem.localdomain.com (vpn1-6-251.ams2.redhat.com [10.36.6.251]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q2U7plEK026017; Fri, 30 Mar 2012 03:51:48 -0400 From: Hans de Goede To: Gerd Hoffmann Date: Fri, 30 Mar 2012 09:53:53 +0200 Message-Id: <1333094034-3682-1-git-send-email-hdegoede@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: Hans de Goede , qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH 1/2] usb-ehci: Drop unused sofv value X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The sofv value only ever gets a value assigned and is never used (read) anywhere, so we can just drop it. Signed-off-by: Hans de Goede --- hw/usb/hcd-ehci.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 53c3c8f..64b58e3 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -403,7 +403,6 @@ struct EHCIState { /* * Internal states, shadow registers, etc */ - uint32_t sofv; QEMUTimer *frame_timer; int attach_poll_counter; int astate; // Current state in asynchronous schedule @@ -1103,10 +1102,6 @@ static void ehci_mem_writel(void *ptr, target_phys_addr_t addr, uint32_t val) val &= USBINTR_MASK; break; - case FRINDEX: - s->sofv = val >> 3; - break; - case CONFIGFLAG: val &= 0x1; if (val) { @@ -2158,9 +2153,6 @@ static void ehci_frame_timer(void *opaque) ehci_set_interrupt(ehci, USBSTS_FLR); ehci->frindex = 0; } - - ehci->sofv = (ehci->frindex - 1) >> 3; - ehci->sofv &= 0x000003ff; } if (frames - i > ehci->maxframes) {